https://bugzilla.redhat.com/show_bug.cgi?id=2279336 --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- This basically looks great, but I want to talk about the Moldavan locale. Please see below. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Notes (no change required): =========================== - It’s not necessary to number Source0; just Source: […] will do. Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Not an issue. While gcc is used indirectly, this is a Vala program and depending on vala suffices. - Regarding the rpmlint message wingpanel-indicator-a11y.x86_64: E: invalid-lc-messages-dir /usr/share/locale/mo/LC_MESSAGES/a11y-indicator.mo it turns out that mo is a deprecated identifier for Moldovan, and it was renamed to ro_MD in iso-codes 4.16.0: https://salsa.debian.org/iso-codes-team/iso-codes/-/blob/v4.16.0/CHANGELOG.md?ref_type=tags#changed We should probably handle this, as the status quo leaves us installing files in unowned directories /usr/share/locale/mo and /usr/share/locale/mo/LC_MESSAGES. This seems to be an issue across pantheon and ElementaryOS packages. It’s an issue in the ElementaryOS apps I maintain (having picked up a few after they were orphaned). Now that I’ve finally figured out what can be done about it, I’ll go fix those too. The following snippet in %prep seems to suffice: rename_lang() { set -ue sed -r -i "s/(Language:[[:blank:]]+)${1}\\b/\\1${2}/" \ "po/${1}.po" "po/extra/${1}.po" mv "po/${1}.po" "po/${2}.po" mv "po/extra/${1}.po" "po/extra/${2}.po" sed -r -i "s/^${1}\$/${2}/" po/LINGUAS po/extra/LINGUAS } # https://salsa.debian.org/iso-codes-team/iso-codes/-/blob/v4.16.0/CHANGELOG.md rename_lang mo ro_MD It would be great if we could point out the problem upstream, but I’m not sure where the the global locale boilerplate for ElementaryOS that’s ending up in all these projects actually lives. I’m also surprised that the other two renamings called out in the iso-codes changelog (nb.po to nb_NO.po, also in 4.16.0, and ku.po to kmr.po in 4.7.0, don’t seem to require similar treatment. ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. The program is built as a plugin/extension for wingpanel and appropriately installed to %{_libdir}/wingpanel/liba11y.so, which is not in the default linker search path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU General Public License, Version 2", "Unknown or generated", "GNU General Public License v2.0 or later". 421 files have unknown license. Detailed output of licensecheck in /home/ben/Downloads/review/2279336-wingpanel- indicator-a11y/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/locale/es/LC_MESSAGES, /usr/share/locale/dv/LC_MESSAGES, /usr/share/locale/rw, /usr/share/locale/fr/LC_MESSAGES, /usr/share/locale/si/LC_MESSAGES, /usr/share/locale/dz/LC_MESSAGES, /usr/lib64, /usr/share/locale/kg/LC_MESSAGES, /usr/share/locale/os/LC_MESSAGES, /usr/share/locale/nr, /usr/share/locale/sn/LC_MESSAGES, /usr/share/locale/zh/LC_MESSAGES, /usr/share/locale/ig/LC_MESSAGES, /usr/share/locale/mn, /usr/share/locale/nv/LC_MESSAGES, /usr/share/locale/az, /usr/share/locale/ks, /usr/share/locale/ho, /usr/share/locale/na, /usr/share/locale/eu/LC_MESSAGES, /usr/lib, /usr/share/locale/hi/LC_MESSAGES, /usr/share/locale/sr/LC_MESSAGES, /usr/share/locale/os, /usr/share/locale/nv, /usr/share/locale/sw/LC_MESSAGES, /usr/share/locale/mi, /usr/share/locale/ia/LC_MESSAGES, /usr, /usr/share/locale/ku, /usr/share/locale/es, /usr/share/locale/hu, /usr/share/locale/bh, /usr/share/locale/ja, /usr/share/locale/tl, /usr/share/locale/ve, /usr/share/locale/uz, /usr/share/locale/wa, /usr/share/locale/ik/LC_MESSAGES, /usr/share/locale/be, /usr/share/locale/ss, /usr/share/locale/szl, /usr/share/locale/tg/LC_MESSAGES, /usr/share/locale/tk, /usr/share/locale/mn/LC_MESSAGES, /usr/share/locale/he/LC_MESSAGES, /usr/share/locale/wo/LC_MESSAGES, /usr/share/locale/ce, /usr/share/locale/ty/LC_MESSAGES, /usr/share/locale/ce/LC_MESSAGES, /usr/share/locale/kv/LC_MESSAGES, /usr/share/locale/kn, /usr/share/locale/ik, /usr/share/locale/sa, /usr/share/locale/rm/LC_MESSAGES, /usr/share/locale/wo, /usr/share/locale/nr/LC_MESSAGES, /usr/share/locale/st/LC_MESSAGES, /usr/share/locale/ab, /usr/share/locale/an, /usr/share/locale/si, /usr/share/locale/ty, /usr/share/locale/yi, /usr/share/locale/ha, /usr/share/locale/ae, /usr/share/locale/ky/LC_MESSAGES, /usr/share/locale/zu/LC_MESSAGES, /usr/share/locale/vi/LC_MESSAGES, /usr/share/locale/as, /usr/share/locale/dv, /usr/share/locale/ml/LC_MESSAGES, /usr/share/locale/eo/LC_MESSAGES, /usr/share/locale/af, /usr/share/locale/bm/LC_MESSAGES, /usr/share/locale/li, /usr/share/locale/lo/LC_MESSAGES, /usr/share/locale/tn, /usr/lib64/wingpanel, /usr/share/locale/na/LC_MESSAGES, /usr/share/locale/ie/LC_MESSAGES, /usr/share/locale/ro, /usr/share/locale/ee/LC_MESSAGES, /usr/share/locale/ka, /usr/share/locale/uz/LC_MESSAGES, /usr/share/locale/ga/LC_MESSAGES, /usr/share/locale/tl/LC_MESSAGES, /usr/share/locale/no, /usr/share/locale/co, /usr/share/locale/oc/LC_MESSAGES, /usr/share/locale/oc, /usr/share/locale/en_CA, /usr/share/locale/ln/LC_MESSAGES, /usr/share/locale/vo, /usr/share/locale/dz, /usr/share/locale/br/LC_MESSAGES, /usr/share/locale/or/LC_MESSAGES, /usr/share/locale/is/LC_MESSAGES, /usr/share/locale/cu/LC_MESSAGES, /usr/share/locale/fj, /usr/share/locale/kk/LC_MESSAGES, /usr/share/locale/sw, /usr/share/locale/cv/LC_MESSAGES, /usr/share/locale/kl, /usr/share/locale/hz, /usr/share/locale/su/LC_MESSAGES, /usr/share/locale/se/LC_MESSAGES, /usr/share/locale/fr_CA/LC_MESSAGES, /usr/share/locale/et, /usr/share/locale/bn, /usr/share/locale/my, /usr/share/locale/ny, /usr/share/locale/ro/LC_MESSAGES, /usr/share/locale/kk, /usr/share/locale/te/LC_MESSAGES, /usr/share/locale/eo, /usr/share/locale/mo, /usr/share/locale/ckb/LC_MESSAGES, /usr/share, /usr/share/locale/th/LC_MESSAGES, /usr/share/locale/ru, /usr/share/locale/kj, /usr/share/locale/ar, /usr/share/locale/lt/LC_MESSAGES, /usr/share/locale/pt_BR/LC_MESSAGES, /usr/share/locale/gv, /usr/share/locale/en_GB/LC_MESSAGES, /usr/share/locale/fi/LC_MESSAGES, /usr/share/locale/xh/LC_MESSAGES, /usr/share/locale/bo, /usr/share/locale/fil, /usr/share/locale/fy, /usr/share/locale/et/LC_MESSAGES, /usr/share/locale/ms, /usr/share/locale/la, /usr/share/locale/gn/LC_MESSAGES, /usr/share/locale/ln, /usr/share/locale/fil/LC_MESSAGES, /usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/ca/LC_MESSAGES, /usr/share/locale/gl/LC_MESSAGES, /usr/share/locale/ab/LC_MESSAGES, /usr/share/locale/da/LC_MESSAGES, /usr/share/locale/ch/LC_MESSAGES, /usr/share/locale/eu, /usr/share/locale/am/LC_MESSAGES, /usr/share/locale/vi, /usr/share/locale/sv, /usr/share/locale/bs, /usr/share/locale/ee, /usr/share/locale/ne/LC_MESSAGES, /usr/share/locale/mg, /usr/share/locale/av, /usr/share/locale/fa, /usr/share/locale/nl, /usr/share/locale/ti, /usr/share/locale/ca@valencia, /usr/share/locale/bg, /usr/share/locale/ug, /usr/share/locale/be/LC_MESSAGES, /usr/share/locale/lu, /usr/share/locale/fa/LC_MESSAGES, /usr/share/locale/sl/LC_MESSAGES, /usr/share/locale/zh_CN, /usr/share/locale/sc, /usr/share/locale/tr, /usr/share/locale/de/LC_MESSAGES, /usr/share/locale/id, /usr/share/locale/az/LC_MESSAGES, /usr/share/locale/gn, /usr/share/locale/ie, /usr/share/locale/zh_HK/LC_MESSAGES, /usr/share/locale/hr/LC_MESSAGES, /usr/share/locale/my/LC_MESSAGES, /usr/share/locale/ps, /usr/share/locale/tw, /usr/share/locale/bg/LC_MESSAGES, /usr/share/locale/ta, /usr/share/locale/ca, /usr/share/locale/iu/LC_MESSAGES, /usr/share/locale/pa/LC_MESSAGES, /usr/share/locale/hu/LC_MESSAGES, /usr/share/locale/cr, /usr/share/locale/ru/LC_MESSAGES, /usr/share/locale/se, /usr/share/locale/sma/LC_MESSAGES, /usr/share/locale/st, /usr/share/locale/ti/LC_MESSAGES, /usr/share/locale/tg, /usr/share/locale/pa, /usr/share/locale/sl, /usr/share/locale/oj/LC_MESSAGES, /usr/share/locale/an/LC_MESSAGES, /usr/share/locale/szl/LC_MESSAGES, /usr/share/doc, /usr/share/locale/fo/LC_MESSAGES, /usr/share/locale/rm, /usr/share/locale/mt/LC_MESSAGES, /usr/share/locale/id/LC_MESSAGES, /usr/share/licenses, /usr/share/locale/gu/LC_MESSAGES, /usr/share/locale/lv, /usr/share/locale/cy, /usr/share/locale/tr/LC_MESSAGES, /usr/share/locale/xh, /usr/share/locale/mr, /usr/share/glib-2.0/schemas, /usr/share/locale/ng, /usr/share/locale/gd/LC_MESSAGES, /usr/share/locale/fr_CA, /usr/share/locale/lg/LC_MESSAGES, /usr/share/locale/li/LC_MESSAGES, /usr/share/locale/ta/LC_MESSAGES, /usr/share/locale/nl/LC_MESSAGES, /usr/share/locale/tt/LC_MESSAGES, /usr/share/locale/ii/LC_MESSAGES, /usr/share/locale/lo, /usr/share/locale/no/LC_MESSAGES, /usr/share/locale/sm/LC_MESSAGES, /usr/share/locale/lb/LC_MESSAGES, /usr/share/locale/ak/LC_MESSAGES, /usr/share/locale/sd, /usr/share/locale/mh, /usr/share/locale/ig, /usr/share/locale/tk/LC_MESSAGES, /usr/share/locale/kr, /usr/share/locale/pi/LC_MESSAGES, /usr/src/debug, /usr/share/locale/kv, /usr/share/locale/th, /usr/share/locale/km/LC_MESSAGES, /usr/share/locale/cv, /usr/share/locale/rn, /usr/share/locale/sq/LC_MESSAGES, /usr/share/locale/to/LC_MESSAGES, /usr/share/locale/sr, /usr/share/locale/cr/LC_MESSAGES, /usr/share/locale/te, /usr/share/locale/zh, /usr/share/locale/sk, /usr/share/locale/nd/LC_MESSAGES, /usr/share/locale/yi/LC_MESSAGES, /usr/share/locale/ay/LC_MESSAGES, /usr/share/locale/it/LC_MESSAGES, /usr/share/locale/km, /usr/share/locale/zh_CN/LC_MESSAGES, /usr/share/locale/kl/LC_MESSAGES, /usr/share/locale/vo/LC_MESSAGES, /usr/share/locale/ff, /usr/share/locale/ps/LC_MESSAGES, /usr/share/locale/en_AU/LC_MESSAGES, /usr/share/locale/en_AU, /usr/share/locale/nb, /usr/share/locale/kn/LC_MESSAGES, /usr/share/locale/gv/LC_MESSAGES, /usr/share/locale/bn/LC_MESSAGES, /usr/share/locale/mk/LC_MESSAGES, /usr/share/locale/uk/LC_MESSAGES, /usr/share/locale/kw/LC_MESSAGES, /usr/share/locale/ml, /usr/share/locale/ny/LC_MESSAGES, /usr/share/locale/lu/LC_MESSAGES, /usr/share/locale/pt, /usr/share/locale/ba, /usr/share/locale/pl/LC_MESSAGES, /usr/share/locale/ur/LC_MESSAGES, /usr/share/locale/jv/LC_MESSAGES, /usr/share/locale/ch, /usr/share/locale/bs/LC_MESSAGES, /usr/share/locale/ng/LC_MESSAGES, /usr/share/locale/el/LC_MESSAGES, /usr/share/locale/rue, /usr/share/locale/ug/LC_MESSAGES, /usr/share/locale/fr, /usr/share/locale/cs/LC_MESSAGES, /usr/share/locale/ga, /usr/share/locale/iu, /usr/share/locale/hi, /usr/share/locale/io, /usr/share/locale/mo/LC_MESSAGES, /usr/share/locale/za/LC_MESSAGES, /usr/share/locale/br, /usr/share/locale/to, /usr/share/locale/ho/LC_MESSAGES, /usr/share/locale/co/LC_MESSAGES, /usr/share/locale/mt, /usr/share/locale/kg, /usr/share/locale/ms/LC_MESSAGES, /usr/share/metainfo, /usr/share/locale/cu, /usr/share/locale/pi, /usr/share/locale/io/LC_MESSAGES, /usr/share/locale/yo, /usr/share/locale/mh/LC_MESSAGES, /usr/share/locale/la/LC_MESSAGES, /usr/share/locale/sq, /usr/share/locale/ne, /usr/share/locale/kr/LC_MESSAGES, /usr/share/locale/ht, /usr/share/locale/mk, /usr/share/locale/ar/LC_MESSAGES, /usr/share/locale/om, /usr/share/locale/am, /usr/share/locale/tn/LC_MESSAGES, /usr/share/locale/nd, /usr/share/locale/ts, /usr/share/locale/it, /usr/share/locale/hy/LC_MESSAGES, /usr/share/locale/af/LC_MESSAGES, /usr/share/locale/ae/LC_MESSAGES, /usr/share/locale/ay, /usr/share/locale/aa/LC_MESSAGES, /usr/share/locale/pt/LC_MESSAGES, /usr/share/locale/kj/LC_MESSAGES, /usr/share/locale/bh/LC_MESSAGES, /usr/share/locale/bm, /usr/share/locale/zu, /usr/share/locale/ur, /usr/share/locale/ii, /usr/share/locale/qu/LC_MESSAGES, /usr/share/locale/da, /usr/share/locale/ja/LC_MESSAGES, /usr/share/locale/pl, /usr/share/locale/el, /usr/share/locale/gd, /usr/share/locale/ss/LC_MESSAGES, /usr/share/locale/ff/LC_MESSAGES, /usr/share/locale/sn, /usr/share/locale/ha/LC_MESSAGES, /usr/share/locale/bi, /usr/share/locale/rw/LC_MESSAGES, /usr/share/locale/om/LC_MESSAGES, /usr/share/locale/sd/LC_MESSAGES, /usr/share/locale/or, /usr/share/locale/ko, /usr/share/locale/sg, /usr/share/locale/hr, /usr/share/locale/mr/LC_MESSAGES, /usr/share/locale/fo, /usr/share/locale/lv/LC_MESSAGES, /usr/share/locale/sv/LC_MESSAGES, /usr/share/locale/lt, /usr/share/locale/ak, /usr/share/locale/so, /usr/share/locale/ki/LC_MESSAGES, /usr/share/locale/za, /usr/share/locale/yo/LC_MESSAGES, /usr/share/locale/zh_HK, /usr/share/locale/gu, /usr/share/locale/sc/LC_MESSAGES, /usr/share/locale/ko/LC_MESSAGES, /usr/share/locale, /usr/share/locale/zh_TW, /usr/share/locale/ht/LC_MESSAGES, /usr/share/locale/bo/LC_MESSAGES, /usr/share/locale/sr@latin, /usr/share/locale/en_GB, /usr/share/locale/he, /usr/share/locale/de, /usr/share/locale/hy, /usr/share/locale/cs, /usr/share/locale/ki, /usr/share/locale/gl, /usr/share/locale/sk/LC_MESSAGES, /usr/share/locale/rn/LC_MESSAGES, /usr/share/locale/lg, /usr/share/locale/mg/LC_MESSAGES, /usr/share/locale/ky, /usr/share/locale/bi/LC_MESSAGES, /usr/src, /usr/share/locale/ca@valencia/LC_MESSAGES, /usr/share/locale/ia, /usr/share/locale/sg/LC_MESSAGES, /usr/share/locale/fj/LC_MESSAGES, /usr/share/locale/ka/LC_MESSAGES, /usr/share/locale/aa, /usr/share/locale/su, /usr/share/locale/fy/LC_MESSAGES, /usr/share/locale/qu, /usr/share/locale/uk, /usr/share/glib-2.0, /usr/share/locale/tw/LC_MESSAGES, /usr/share/locale/tt, /usr/share/locale/nn, /usr/share/locale/cy/LC_MESSAGES, /usr/share/locale/jv, /usr/share/locale/nn/LC_MESSAGES, /usr/share/locale/so/LC_MESSAGES, /usr/share/locale/sma, /usr/share/locale/fi, /usr/share/locale/ku/LC_MESSAGES, /usr/share/locale/ckb, /usr/share/locale/ast, /usr/share/locale/wa/LC_MESSAGES, /usr/share/locale/ts/LC_MESSAGES, /usr/share/locale/sa/LC_MESSAGES, /usr/share/locale/pt_BR, /usr/share/locale/av/LC_MESSAGES, /usr/share/locale/zh_TW/LC_MESSAGES, /usr/share/locale/oj, /usr/share/locale/as/LC_MESSAGES, /usr/share/locale/en_CA/LC_MESSAGES, /usr/share/locale/sm, /usr/share/locale/is, /usr/share/locale/hz/LC_MESSAGES, /usr/share/locale/lb, /usr/share/locale/ast/LC_MESSAGES, /usr/share/locale/sr@latin/LC_MESSAGES, /usr/share/locale/nb/LC_MESSAGES, /usr/share/locale/ks/LC_MESSAGES, /usr/share/locale/kw, /usr/share/locale/mi/LC_MESSAGES, /usr/share/locale/ve/LC_MESSAGES, /usr/share/locale/ba/LC_MESSAGES Spurious diagnostics (fedora-review bug). The wingpanel dependency provides %{_libdir}/wingpanel. See Issues regarding /usr/share/locale/mo and /usr/share/locale/mo/LC_MESSAGES. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/locale/es/LC_MESSAGES, /usr/share/locale/dv/LC_MESSAGES, /usr/share/locale/rw, /usr/share/locale/fr/LC_MESSAGES, /usr/share/locale/si/LC_MESSAGES, /usr/share/locale/dz/LC_MESSAGES, /usr/lib64, /usr/share/locale/kg/LC_MESSAGES, /usr/share/locale/os/LC_MESSAGES, /usr/share/locale/nr, /usr/share/locale/sn/LC_MESSAGES, /usr/share/locale/zh/LC_MESSAGES, /usr/share/locale/ig/LC_MESSAGES, /usr/share/locale/mn, /usr/share/locale/nv/LC_MESSAGES, /usr/share/locale/az, /usr/share/locale/ks, /usr/share/locale/ho, /usr/share/locale/na, /usr/share/locale/eu/LC_MESSAGES, /usr/lib, /usr/share/locale/hi/LC_MESSAGES, /usr/share/locale/sr/LC_MESSAGES, /usr/share/locale/os, /usr/share/locale/nv, /usr/share/locale/sw/LC_MESSAGES, /usr/share/locale/mi, /usr/share/locale/ia/LC_MESSAGES, /usr, /usr/share/locale/ku, /usr/share/locale/es, /usr/share/locale/hu, /usr/share/locale/bh, /usr/share/locale/ja, /usr/share/locale/tl, /usr/share/locale/ve, /usr/share/locale/uz, /usr/share/locale/wa, /usr/share/locale/ik/LC_MESSAGES, /usr/share/locale/be, /usr/share/locale/ss, /usr/share/locale/szl, /usr/share/locale/tg/LC_MESSAGES, /usr/share/locale/tk, /usr/share/locale/mn/LC_MESSAGES, /usr/share/locale/he/LC_MESSAGES, /usr/share/locale/wo/LC_MESSAGES, /usr/share/locale/ce, /usr/share/locale/ty/LC_MESSAGES, /usr/share/locale/ce/LC_MESSAGES, /usr/share/locale/kv/LC_MESSAGES, /usr/share/locale/kn, /usr/share/locale/ik, /usr/share/locale/sa, /usr/share/locale/rm/LC_MESSAGES, /usr/share/locale/wo, /usr/share/locale/nr/LC_MESSAGES, /usr/share/locale/st/LC_MESSAGES, /usr/share/locale/ab, /usr/share/locale/an, /usr/share/locale/si, /usr/share/locale/ty, /usr/share/locale/yi, /usr/share/locale/ha, /usr/share/locale/ae, /usr/share/locale/ky/LC_MESSAGES, /usr/share/locale/zu/LC_MESSAGES, /usr/share/locale/vi/LC_MESSAGES, /usr/share/locale/as, /usr/share/locale/dv, /usr/share/locale/ml/LC_MESSAGES, /usr/share/locale/eo/LC_MESSAGES, /usr/share/locale/af, /usr/share/locale/bm/LC_MESSAGES, /usr/share/locale/li, /usr/share/locale/lo/LC_MESSAGES, /usr/share/locale/tn, /usr/lib64/wingpanel, /usr/share/locale/na/LC_MESSAGES, /usr/share/locale/ie/LC_MESSAGES, /usr/share/locale/ro, /usr/share/locale/ee/LC_MESSAGES, /usr/share/locale/ka, /usr/share/locale/uz/LC_MESSAGES, /usr/share/locale/ga/LC_MESSAGES, /usr/share/locale/tl/LC_MESSAGES, /usr/share/locale/no, /usr/share/locale/co, /usr/share/locale/oc/LC_MESSAGES, /usr/share/locale/oc, /usr/share/locale/en_CA, /usr/share/locale/ln/LC_MESSAGES, /usr/share/locale/vo, /usr/share/locale/dz, /usr/share/locale/br/LC_MESSAGES, /usr/share/locale/or/LC_MESSAGES, /usr/share/locale/is/LC_MESSAGES, /usr/share/locale/cu/LC_MESSAGES, /usr/share/locale/fj, /usr/share/locale/kk/LC_MESSAGES, /usr/share/locale/sw, /usr/share/locale/cv/LC_MESSAGES, /usr/share/locale/kl, /usr/share/locale/hz, /usr/share/locale/su/LC_MESSAGES, /usr/share/locale/se/LC_MESSAGES, /usr/share/locale/fr_CA/LC_MESSAGES, /usr/share/locale/et, /usr/share/locale/bn, /usr/share/locale/my, /usr/share/locale/ny, /usr/share/locale/ro/LC_MESSAGES, /usr/share/locale/kk, /usr/share/locale/te/LC_MESSAGES, /usr/share/locale/eo, /usr/share/locale/mo, /usr/share/locale/ckb/LC_MESSAGES, /usr/share, /usr/share/locale/th/LC_MESSAGES, /usr/share/locale/ru, /usr/share/locale/kj, /usr/share/locale/ar, /usr/share/locale/lt/LC_MESSAGES, /usr/share/locale/pt_BR/LC_MESSAGES, /usr/share/locale/gv, /usr/share/locale/en_GB/LC_MESSAGES, /usr/share/locale/fi/LC_MESSAGES, /usr/share/locale/xh/LC_MESSAGES, /usr/share/locale/bo, /usr/share/locale/fil, /usr/share/locale/fy, /usr/share/locale/et/LC_MESSAGES, /usr/share/locale/ms, /usr/share/locale/la, /usr/share/locale/gn/LC_MESSAGES, /usr/share/locale/ln, /usr/share/locale/fil/LC_MESSAGES, /usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/ca/LC_MESSAGES, /usr/share/locale/gl/LC_MESSAGES, /usr/share/locale/ab/LC_MESSAGES, /usr/share/locale/da/LC_MESSAGES, /usr/share/locale/ch/LC_MESSAGES, /usr/share/locale/eu, /usr/share/locale/am/LC_MESSAGES, /usr/share/locale/vi, /usr/share/locale/sv, /usr/share/locale/bs, /usr/share/locale/ee, /usr/share/locale/ne/LC_MESSAGES, /usr/share/locale/mg, /usr/share/locale/av, /usr/share/locale/fa, /usr/share/locale/nl, /usr/share/locale/ti, /usr/share/locale/ca@valencia, /usr/share/locale/bg, /usr/share/locale/ug, /usr/share/locale/be/LC_MESSAGES, /usr/share/locale/lu, /usr/share/locale/fa/LC_MESSAGES, /usr/share/locale/sl/LC_MESSAGES, /usr/share/locale/zh_CN, /usr/share/locale/sc, /usr/share/locale/tr, /usr/share/locale/de/LC_MESSAGES, /usr/share/locale/id, /usr/share/locale/az/LC_MESSAGES, /usr/share/locale/gn, /usr/share/locale/ie, /usr/share/locale/zh_HK/LC_MESSAGES, /usr/share/locale/hr/LC_MESSAGES, /usr/share/locale/my/LC_MESSAGES, /usr/share/locale/ps, /usr/share/locale/tw, /usr/share/locale/bg/LC_MESSAGES, /usr/share/locale/ta, /usr/share/locale/ca, /usr/share/locale/iu/LC_MESSAGES, /usr/share/locale/pa/LC_MESSAGES, /usr/share/locale/hu/LC_MESSAGES, /usr/share/locale/cr, /usr/share/locale/ru/LC_MESSAGES, /usr/share/locale/se, /usr/share/locale/sma/LC_MESSAGES, /usr/share/locale/st, /usr/share/locale/ti/LC_MESSAGES, /usr/share/locale/tg, /usr/share/locale/pa, /usr/share/locale/sl, /usr/share/locale/oj/LC_MESSAGES, /usr/share/locale/an/LC_MESSAGES, /usr/share/locale/szl/LC_MESSAGES, /usr/share/doc, /usr/share/locale/fo/LC_MESSAGES, /usr/share/locale/rm, /usr/share/locale/mt/LC_MESSAGES, /usr/share/locale/id/LC_MESSAGES, /usr/share/licenses, /usr/share/locale/gu/LC_MESSAGES, /usr/share/locale/lv, /usr/share/locale/cy, /usr/share/locale/tr/LC_MESSAGES, /usr/share/locale/xh, /usr/share/locale/mr, /usr/share/glib-2.0/schemas, /usr/share/locale/ng, /usr/share/locale/gd/LC_MESSAGES, /usr/share/locale/fr_CA, /usr/share/locale/lg/LC_MESSAGES, /usr/share/locale/li/LC_MESSAGES, /usr/share/locale/ta/LC_MESSAGES, /usr/share/locale/nl/LC_MESSAGES, /usr/share/locale/tt/LC_MESSAGES, /usr/share/locale/ii/LC_MESSAGES, /usr/share/locale/lo, /usr/share/locale/no/LC_MESSAGES, /usr/share/locale/sm/LC_MESSAGES, /usr/share/locale/lb/LC_MESSAGES, /usr/share/locale/ak/LC_MESSAGES, /usr/share/locale/sd, /usr/share/locale/mh, /usr/share/locale/ig, /usr/share/locale/tk/LC_MESSAGES, /usr/share/locale/kr, /usr/share/locale/pi/LC_MESSAGES, /usr/src/debug, /usr/share/locale/kv, /usr/share/locale/th, /usr/share/locale/km/LC_MESSAGES, /usr/share/locale/cv, /usr/share/locale/rn, /usr/share/locale/sq/LC_MESSAGES, /usr/share/locale/to/LC_MESSAGES, /usr/share/locale/sr, /usr/share/locale/cr/LC_MESSAGES, /usr/share/locale/te, /usr/share/locale/zh, /usr/share/locale/sk, /usr/share/locale/nd/LC_MESSAGES, /usr/share/locale/yi/LC_MESSAGES, /usr/share/locale/ay/LC_MESSAGES, /usr/share/locale/it/LC_MESSAGES, /usr/share/locale/km, /usr/share/locale/zh_CN/LC_MESSAGES, /usr/share/locale/kl/LC_MESSAGES, /usr/share/locale/vo/LC_MESSAGES, /usr/share/locale/ff, /usr/share/locale/ps/LC_MESSAGES, /usr/share/locale/en_AU/LC_MESSAGES, /usr/share/locale/en_AU, /usr/share/locale/nb, /usr/share/locale/kn/LC_MESSAGES, /usr/share/locale/gv/LC_MESSAGES, /usr/share/locale/bn/LC_MESSAGES, /usr/share/locale/mk/LC_MESSAGES, /usr/share/locale/uk/LC_MESSAGES, /usr/share/locale/kw/LC_MESSAGES, /usr/share/locale/ml, /usr/share/locale/ny/LC_MESSAGES, /usr/share/locale/lu/LC_MESSAGES, /usr/share/locale/pt, /usr/share/locale/ba, /usr/share/locale/pl/LC_MESSAGES, /usr/share/locale/ur/LC_MESSAGES, /usr/share/locale/jv/LC_MESSAGES, /usr/share/locale/ch, /usr/share/locale/bs/LC_MESSAGES, /usr/share/locale/ng/LC_MESSAGES, /usr/share/locale/el/LC_MESSAGES, /usr/share/locale/rue, /usr/share/locale/ug/LC_MESSAGES, /usr/share/locale/fr, /usr/share/locale/cs/LC_MESSAGES, /usr/share/locale/ga, /usr/share/locale/iu, /usr/share/locale/hi, /usr/share/locale/io, /usr/share/locale/mo/LC_MESSAGES, /usr/share/locale/za/LC_MESSAGES, /usr/share/locale/br, /usr/share/locale/to, /usr/share/locale/ho/LC_MESSAGES, /usr/share/locale/co/LC_MESSAGES, /usr/share/locale/mt, /usr/share/locale/kg, /usr/share/locale/ms/LC_MESSAGES, /usr/share/metainfo, /usr/share/locale/cu, /usr/share/locale/pi, /usr/share/locale/io/LC_MESSAGES, /usr/share/locale/yo, /usr/share/locale/mh/LC_MESSAGES, /usr/share/locale/la/LC_MESSAGES, /usr/share/locale/sq, /usr/share/locale/ne, /usr/share/locale/kr/LC_MESSAGES, /usr/share/locale/ht, /usr/share/locale/mk, /usr/share/locale/ar/LC_MESSAGES, /usr/share/locale/om, /usr/share/locale/am, /usr/share/locale/tn/LC_MESSAGES, /usr/share/locale/nd, /usr/share/locale/ts, /usr/share/locale/it, /usr/share/locale/hy/LC_MESSAGES, /usr/share/locale/af/LC_MESSAGES, /usr/share/locale/ae/LC_MESSAGES, /usr/share/locale/ay, /usr/share/locale/aa/LC_MESSAGES, /usr/share/locale/pt/LC_MESSAGES, /usr/share/locale/kj/LC_MESSAGES, /usr/share/locale/bh/LC_MESSAGES, /usr/share/locale/bm, /usr/share/locale/zu, /usr/share/locale/ur, /usr/share/locale/ii, /usr/share/locale/qu/LC_MESSAGES, /usr/share/locale/da, /usr/share/locale/ja/LC_MESSAGES, /usr/share/locale/pl, /usr/share/locale/el, /usr/share/locale/gd, /usr/share/locale/ss/LC_MESSAGES, /usr/share/locale/ff/LC_MESSAGES, /usr/share/locale/sn, /usr/share/locale/ha/LC_MESSAGES, /usr/share/locale/bi, /usr/share/locale/rw/LC_MESSAGES, /usr/share/locale/om/LC_MESSAGES, /usr/share/locale/sd/LC_MESSAGES, /usr/share/locale/or, /usr/share/locale/ko, /usr/share/locale/sg, /usr/share/locale/hr, /usr/share/locale/mr/LC_MESSAGES, /usr/share/locale/fo, /usr/share/locale/lv/LC_MESSAGES, /usr/share/locale/sv/LC_MESSAGES, /usr/share/locale/lt, /usr/share/locale/ak, /usr/share/locale/so, /usr/share/locale/ki/LC_MESSAGES, /usr/share/locale/za, /usr/share/locale/yo/LC_MESSAGES, /usr/share/locale/zh_HK, /usr/share/locale/gu, /usr/share/locale/sc/LC_MESSAGES, /usr/share/locale/ko/LC_MESSAGES, /usr/share/locale, /usr/share/locale/zh_TW, /usr/share/locale/ht/LC_MESSAGES, /usr/share/locale/bo/LC_MESSAGES, /usr/share/locale/sr@latin, /usr/share/locale/en_GB, /usr/share/locale/he, /usr/share/locale/de, /usr/share/locale/hy, /usr/share/locale/cs, /usr/share/locale/ki, /usr/share/locale/gl, /usr/share/locale/sk/LC_MESSAGES, /usr/share/locale/rn/LC_MESSAGES, /usr/share/locale/lg, /usr/share/locale/mg/LC_MESSAGES, /usr/share/locale/ky, /usr/share/locale/bi/LC_MESSAGES, /usr/src, /usr/share/locale/ca@valencia/LC_MESSAGES, /usr/share/locale/ia, /usr/share/locale/sg/LC_MESSAGES, /usr/share/locale/fj/LC_MESSAGES, /usr/share/locale/ka/LC_MESSAGES, /usr/share/locale/aa, /usr/share/locale/su, /usr/share/locale/fy/LC_MESSAGES, /usr/share/locale/qu, /usr/share/locale/uk, /usr/share/glib-2.0, /usr/share/locale/tw/LC_MESSAGES, /usr/share/locale/tt, /usr/share/locale/nn, /usr/share/locale/cy/LC_MESSAGES, /usr/share/locale/jv, /usr/share/locale/nn/LC_MESSAGES, /usr/share/locale/so/LC_MESSAGES, /usr/share/locale/sma, /usr/share/locale/fi, /usr/share/locale/ku/LC_MESSAGES, /usr/share/locale/ckb, /usr/share/locale/ast, /usr/share/locale/wa/LC_MESSAGES, /usr/share/locale/ts/LC_MESSAGES, /usr/share/locale/sa/LC_MESSAGES, /usr/share/locale/pt_BR, /usr/share/locale/av/LC_MESSAGES, /usr/share/locale/zh_TW/LC_MESSAGES, /usr/share/locale/oj, /usr/share/locale/as/LC_MESSAGES, /usr/share/locale/en_CA/LC_MESSAGES, /usr/share/locale/sm, /usr/share/locale/is, /usr/share/locale/hz/LC_MESSAGES, /usr/share/locale/lb, /usr/share/locale/ast/LC_MESSAGES, /usr/share/locale/sr@latin/LC_MESSAGES, /usr/share/locale/nb/LC_MESSAGES, /usr/share/locale/ks/LC_MESSAGES, /usr/share/locale/kw, /usr/share/locale/mi/LC_MESSAGES, /usr/share/locale/ve/LC_MESSAGES, /usr/share/locale/ba/LC_MESSAGES Spurious diagnostics (fedora-review bug). [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. As an extension/plugin, it makes sense that this does not have its own desktop file. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 558 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. I did not attempt to test this; I assume you will find any obvious issues by interactive testing. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. (AppStream XML validation only) [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: wingpanel-indicator-a11y-1.0.2-1.fc41.x86_64.rpm wingpanel-indicator-a11y-debuginfo-1.0.2-1.fc41.x86_64.rpm wingpanel-indicator-a11y-debugsource-1.0.2-1.fc41.x86_64.rpm wingpanel-indicator-a11y-1.0.2-1.fc41.src.rpm =========================================================================================== rpmlint session starts ========================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp08bgb0rh')] checks: 32, packages: 4 wingpanel-indicator-a11y.x86_64: E: invalid-lc-messages-dir /usr/share/locale/mo/LC_MESSAGES/a11y-indicator.mo ===================================================== 4 packages and 0 specfiles checked; 1 errors, 0 warnings, 16 filtered, 1 badness; has taken 0.4 s ===================================================== Rpmlint (debuginfo) ------------------- Checking: wingpanel-indicator-a11y-debuginfo-1.0.2-1.fc41.x86_64.rpm =========================================================================================== rpmlint session starts ========================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqv5b3uqs')] checks: 32, packages: 1 ====================================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s ===================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 wingpanel-indicator-a11y.x86_64: E: invalid-lc-messages-dir /usr/share/locale/mo/LC_MESSAGES/a11y-indicator.mo 3 packages and 0 specfiles checked; 1 errors, 0 warnings, 13 filtered, 1 badness; has taken 0.4 s Unversioned so-files -------------------- wingpanel-indicator-a11y: /usr/lib64/wingpanel/liba11y.so Source checksums ---------------- https://github.com/elementary/wingpanel-indicator-a11y/archive/1.0.2/wingpanel-indicator-a11y-1.0.2.tar.gz : CHECKSUM(SHA256) this package : 8cd18c2a13eb5ec91e7fc12628349cc1980f234b61bd5b5ea81340b06f8a6999 CHECKSUM(SHA256) upstream package : 8cd18c2a13eb5ec91e7fc12628349cc1980f234b61bd5b5ea81340b06f8a6999 Requires -------- wingpanel-indicator-a11y (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgdk-3.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgranite.so.6()(64bit) libgtk-3.so.0()(64bit) libwingpanel.so.3()(64bit) rtld(GNU_HASH) wingpanel(x86-64) wingpanel-indicator-a11y-debuginfo (rpmlib, GLIBC filtered): wingpanel-indicator-a11y-debugsource (rpmlib, GLIBC filtered): Provides -------- wingpanel-indicator-a11y: metainfo() metainfo(io.elementary.wingpanel.a11y.metainfo.xml) wingpanel-indicator-a11y wingpanel-indicator-a11y(x86-64) wingpanel-indicator-a11y-debuginfo: debuginfo(build-id) liba11y.so-1.0.2-1.fc41.x86_64.debug()(64bit) wingpanel-indicator-a11y-debuginfo wingpanel-indicator-a11y-debuginfo(x86-64) wingpanel-indicator-a11y-debugsource: wingpanel-indicator-a11y-debugsource wingpanel-indicator-a11y-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2279336 --mock-options=--dnf Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Perl, fonts, Python, Java, Ocaml, SugarActivity, R, PHP, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2279336 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279336%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
