Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cpipe - Counting pipe https://bugzilla.redhat.com/show_bug.cgi?id=427662 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-01-22 11:04 EST ------- A few comments: (In reply to comment #1) > %{__chmod} 0644 %{buildroot}%{_mandir}/man1/%{name}* > - it is not necessary, just add %attr(0644, root, root) before this file in > %files section. My opinition is always that setting modes/permissions by %attr should be avoided unless needed (such as using non-usual users, or setting setuid). Especially, changing permission by %attr often bears unwilling results for debuginfo rpms (using %attr(0755,root,root) but not changing permission correctly by the time %install ends makes binaries not stripped) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review