[Bug 2277389] Review Request: rust-bisection - Rust implementation of the Python bisect module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2277389



--- Comment #11 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
(In reply to Fabio Valentini from comment #7)
> The project looks pretty dead :(
> 
> Thank you for filing the issue / PR upstream, but I'm not hopeful that it
> will do anything.
> 
> If uv / async_http_range_reader really needs this crate, it might be a good
> idea to fork it.
> 
> The upstream repo also has an open issue about a correctness bug (integer
> overflow in mid-point calculation) which would be good to fix.

Does this attempt at replacing the crate with standard-library functionality
look correct to you?

https://github.com/musicinmybrain/async_http_range_reader/commit/dde1525a6fab737f74ba426a0ab4f4c1b30988af

The tests in async_http_range_reader pass with that change, but I don’t have
too much confidence in its test coverage, and I would appreciate a second
person looking at the documentation.

https://doc.rust-lang.org/std/vec/struct.Vec.html#method.partition_point

https://docs.rs/bisection/latest/bisection/fn.bisect_left.html
https://docs.rs/bisection/latest/bisection/fn.bisect_right.html


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2277389

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277389%23c11
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux