https://bugzilla.redhat.com/show_bug.cgi?id=2278420 --- Comment #4 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> --- Great. Thanks for your fast package review. It may take me a bit longer to do the same, because this is my first review ever. Those are my first remarks: 1) Did you went through the rpmlint list? Following warnings/errors seem reasonable. python3-jupytext.noarch: W: python-leftover-require python-jupyter-filesystem ppython3-jupyterlab-jupytext.noarch: E: backup-file-in-package /usr/share/jupyter/labextensions/jupyterlab-jupytext/schemas/jupyterlab-jupytext/package.json.orig 2) Is this already solved? License file 834.90ed5e1570392532523d.js.LICENSE.txt is not marked as %license 3) python-jupytext-doc is provided and I believe it should be python3-jupytext-doc. 4) Is this needed in Requires? The project uses pyproject.toml. BuildRequires: %{py3_dist setuptools} 5) Is this needed in Requires? You don't seem to be calling npm. BuildRequires: nodejs-npm 6) There seem to be a couple of unowned directories like e.g. /etc/jupyter and I believe that's not allowed according to https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ 7) I still haven't looked into the package, but aren't those bundled libraries that require the FPC exception as in "Package contains no bundled libraries without FPC exception."? Have you already got this exception? # base64-js: MIT # buffer: MIT # ieee754: BSD-3-Clause -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2278420 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202278420%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
