https://bugzilla.redhat.com/show_bug.cgi?id=2254926 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-512 83de0576b5d2ea7c3757fa5b4279463055be3c043cab5256a0adc44d0a20d9b7e826fa97cc8c92110ed8758af4af2bd0d8601c852188f9526d71f8bf12324b98) is original. Ok. Summary verified from lib/AnyEvent/Connector.pm. TODO: "Tcp_connect" is cryptic in the summary. It stands for AnyEvent::Socket::tcp_connect(). I recommend replacing "Tcp_connect" with general "TCP connect". Another option is long "AnyEvent::Socket::tcp_connect". Description verified from lib/AnyEvent/Connector.pm. Ok. License verified from Build.PL, README, and lib/AnyEvent/Connector.pm. Ok. No XS code, noarch BuildArch is Ok. All tests pass. Ok. $ rpmlint perl-AnyEvent-Connector.spec ../SRPMS/perl-AnyEvent-Connector-0.04-4.fc41.src.rpm ../RPMS/noarch/perl-AnyEvent-Connector-0.04-4.fc41.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-AnyEvent-Connector.noarch: E: spelling-error ('Tcp', 'Summary(en_US) Tcp -> Tc, Twp, Tc p') perl-AnyEvent-Connector.src: E: spelling-error ('Tcp', 'Summary(en_US) Tcp -> Tc, Twp, Tc p') === 2 packages and 1 specfiles checked; 2 errors, 0 warnings, 8 filtered, 2 badness; has taken 0.3 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-AnyEvent-Connector-0.04-4.fc41.noarch.rpm drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/doc/perl-AnyEvent-Connector -rw-r--r-- 1 root root 439 Nov 7 2023 /usr/share/doc/perl-AnyEvent-Connector/Changes -rw-r--r-- 1 root root 1610 Nov 7 2023 /usr/share/doc/perl-AnyEvent-Connector/README -rw-r--r-- 1 root root 2884 Mar 8 01:00 /usr/share/man/man3/AnyEvent::Connector.3pm.gz -rw-r--r-- 1 root root 916 Mar 8 01:00 /usr/share/man/man3/AnyEvent::Connector::Proxy::http.3pm.gz drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/perl5/vendor_perl/AnyEvent/Connector -rw-r--r-- 1 root root 7721 Mar 8 01:00 /usr/share/perl5/vendor_perl/AnyEvent/Connector.pm drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/perl5/vendor_perl/AnyEvent/Connector/Proxy -rw-r--r-- 1 root root 1977 Mar 8 01:00 /usr/share/perl5/vendor_perl/AnyEvent/Connector/Proxy/http.pm FIX: Package %{perl_vendorlib}/AnyEvent directory. None of the dependencies deliver it. $ rpm -q --requires -p ../RPMS/noarch/perl-AnyEvent-Connector-0.04-4.fc41.noarch.rpm | sort -f | uniq -c 1 perl(AnyEvent::Connector::Proxy::http) 1 perl(AnyEvent::Handle) 1 perl(AnyEvent::Socket) 1 perl(Carp) 1 perl(strict) 1 perl(URI) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-AnyEvent-Connector-0.04-4.fc41.noarch.rpm | sort -f | uniq -c 1 perl(AnyEvent::Connector) = 0.04 1 perl(AnyEvent::Connector::Proxy::http) 1 perl-AnyEvent-Connector = 0.04-4.fc41 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-AnyEvent-Connector-0.04-4.fc41.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=117380297). Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Please correct the FIX item and consider fixing the TODO item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2254926 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254926%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
