https://bugzilla.redhat.com/show_bug.cgi?id=2279277 --- Comment #3 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- > Source0: https://github.com/jarikomppa/emu8051/archive/%{gitcommit}.tar.gz#/%{name}-%{gitcommit}.tar.gz You can utilize github arbitrary download names instead of the RPM hacks, e.g.: Source0: https://github.com/jarikomppa/emu8051/archive/%{gitcommit}/%{name}-%{gitcommit}.tar.gz > BuildRequires: gcc make Maybe better to add each requirement on individual line. It's better to manage and more clear, e.g. you can easily comment out individual deps. > sed -e "s,^BIN := emu,BIN := %{name}," -i Makefile Why not just use: %make_build BIN=%{name} You could omit 'sed' build requirement then. > install -m 0755 %{name} %{buildroot}%{_bindir}/%{name} Please use '-p' to preserve time stamps. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2279277 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279277%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
