[Bug 2277337] Review Request: gtk4-layer-shell - Library to create panels and other desktop components for Wayland

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2277337

Felix Wang <topazus@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #7 from Felix Wang <topazus@xxxxxxxxxxx> ---
A minor issue:

> /usr/lib64/libgtk4-layer-shell.so.0
> /usr/lib64/libgtk4-layer-shell.so.1.0.2

In your spec file, you use %{_libdir}/lib%{name}.so.* to include these two
files.
https://github.com/wmww/gtk4-layer-shell/blob/a689a399d37d174f2e93442e3adc931a9d8dee90/src/meson.build#L18-L19
Well, My suggested revision is:

%{_libdir}/lib%{name}.so.0
%{_libdir}/lib%{name}.so.%{version}

Hope it may facilitate you to catch the soversion bump. This amendment can be
adopted 
when you import this if you would like to do.

The package is approved.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2277337

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277337%23c7
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux