[Bug 2254918] Review Request: perl-Module-Build-Prereqs-FromCPANfile - Construct prereq parameters of Module::Build from cpanfile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2254918

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #6 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Changes in the spec file:

--- perl-Module-Build-Prereqs-FromCPANfile.spec.old     2024-03-08
01:00:00.000000000 +0100
+++ perl-Module-Build-Prereqs-FromCPANfile.spec 2024-05-03 02:00:00.000000000
+0200
@@ -1,13 +1,13 @@
 Name:           perl-Module-Build-Prereqs-FromCPANfile
 Version:        0.02
-Release:        4%{?dist}
+Release:        5%{?dist}
 Summary:        Construct prereq parameters of Module::Build from cpanfile
 License:        GPL-1.0-or-later OR Artistic-1.0-Perl
 URL:            https://metacpan.org/dist/Module-Build-Prereqs-FromCPANfile
 Source0:       
https://cpan.metacpan.org/authors/id/T/TO/TOSHIOITO/Module-Build-Prereqs-FromCPANfile-%{version}.tar.gz
 BuildArch:      noarch
 BuildRequires:  perl-interpreter perl-generators coreutils
-BuildRequires:  perl(:VERSION) >= 5.14.0
+BuildRequires:  perl(:VERSION) >= 5.6.0
 BuildRequires:  perl(CPAN::Meta::Prereqs) >= 2.132830
 BuildRequires:  perl(Exporter)
 BuildRequires:  perl(Module::Build) >= 0.42
@@ -16,7 +16,7 @@
 BuildRequires:  perl(version) >= 0.80
 BuildRequires:  perl(strict)
 BuildRequires:  perl(warnings)
-Recommends:     perl(Module::Build) >= 0.4004
+Requires:       perl(Module::Build) >= 0.4004

 %description
 This simple module reads cpanfile and converts its content into valid
@@ -42,6 +42,9 @@
 %{_mandir}/man3/Module::Build::Prereqs*

 %changelog
+* Fri May 03 2024 Chris Adams <linux@xxxxxxxxxxx> 0.02-5
+- additional spec file cleanups
+
 * Fri Mar 08 2024 Chris Adams <linux@xxxxxxxxxxx> 0.02-4
 - additional spec file cleanups


$ rpmlint perl-Module-Build-Prereqs-FromCPANfile.spec
../SRPMS/perl-Module-Build-Prereqs-FromCPANfile-0.02-5.fc41.src.rpm
../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-5.fc41.noarch.rpm 
======================================== rpmlint session starts
=======================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

=== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0
badness; has taken 0.3 s ==
rpmlint is Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-5.fc41.noarch.rpm |
sort -f | uniq -c
      1 perl(CPAN::Meta::Prereqs) >= 2.132830
      1 perl(Exporter)
      1 perl(Module::Build) >= 0.4004
      1 perl(Module::CPANfile) >= 1.0000
      1 perl(strict)
      1 perl(version) >= 0.80
      1 perl(warnings)
      1 perl-libs
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ resolvedeps rawhide 
../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-5.fc41.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in Fedora 41
(https://koji.fedoraproject.org/koji/taskinfo?taskID=117325797). Ok.

The package is in line with Fedora and Perl packaging guidelines.
The pacakge is APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2254918

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254918%23c6
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux