https://bugzilla.redhat.com/show_bug.cgi?id=2277280 --- Comment #3 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License file installed when any subpackage combination is installed. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. https://github.com/labapart/gattlib/issues/128 noted in the specfile. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/pkgconfig pkgconf-pkg-config [!]: Package contains no bundled libraries without FPC exception. It seems bluez is bundled in some form? Maybe it's just in the source and the following addresses this: # Set shared library version sed -i {bluez,dbus}/CMakeLists.txt \ -e '/add_library(%{name}/aset_target_properties(%{name} PROPERTIES VERSION %{version})' [!]: Latest version is packaged. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. Latest version includes the referenced patch. [!]: %check is present and all tests pass. Doesn't seem upstream has checks. Does that mean this passes? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2277280 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277280%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
