https://bugzilla.redhat.com/show_bug.cgi?id=2277528 --- Comment #3 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "GNU General Public License, Version 3", "zlib License", "Apache License 1.1", "MIT License and/or The Unlicense", "BSD 2-Clause License". 528 files have unknown license. [!]: License file installed when any subpackage combination is installed. Looks like there is some stuff in redist that needs to be addressed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/udev/rules.d, /usr/lib/udev, /usr/lib64/pkgconfig systemd-udev pkgconf-pkg-config [!]: Package contains no bundled libraries without FPC exception. I want to note there is bundled statically linked libraries and I don't know if it passes https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling (I suspect it does and I think we should continue with this strategy for all of the XR stuff.) [!]: Package is not known to require an ExcludeArch tag. With the 32bit tests not being reliable, should we exclude? [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. I've noticed a pattern of adding "downstream-only: why it's downstream only and what it does" as a good comment for patches that we don't intend on sending upstream. [!]: %check is present and all tests pass. See comment about 32bit. Based on my understanding of the policy, the following is acceptable because the so-files are outside of the default LD path. Unversioned so-files -------------------- libsurvive: /usr/lib64/libsurvive/plugins/disambiguator_statebased.so libsurvive: /usr/lib64/libsurvive/plugins/driver_dummy.so libsurvive: /usr/lib64/libsurvive/plugins/driver_global_scene_solver.so libsurvive: /usr/lib64/libsurvive/plugins/driver_playback.so libsurvive: /usr/lib64/libsurvive/plugins/driver_simulator.so libsurvive: /usr/lib64/libsurvive/plugins/driver_udp.so libsurvive: /usr/lib64/libsurvive/plugins/driver_usbmon.so libsurvive: /usr/lib64/libsurvive/plugins/driver_vive.so libsurvive: /usr/lib64/libsurvive/plugins/poser_barycentric_svd.so libsurvive: /usr/lib64/libsurvive/plugins/poser_dummy.so libsurvive: /usr/lib64/libsurvive/plugins/poser_kalman_only.so libsurvive: /usr/lib64/libsurvive/plugins/poser_mpfit.so -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2277528 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277528%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
