Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: texinfo https://bugzilla.redhat.com/show_bug.cgi?id=226488 ------- Additional Comments From vcrhonek@xxxxxxxxxx 2008-01-22 04:50 EST ------- (In reply to comment #1) > I don't understand exactly why the __spec_install_post is redefined. > It seems to me that brp-compress leaves dir as is. I have tried > to remove the %define and things seems to be right. Agree. I don't know exact purpose of it too (with the exception of what's written in #16120), but I have got same result as you. I think we can remove it. > > Prereq should be Requires(.). At least I think so, although > this is not obvious with trigger/Requires(.) interactions. I know PreReq is deprecated. IIRC Requires is practically PreReq without strict package order and since there is only one package in PreReq, Requires should do the same thing. Am I right? > > The manual gzip are bad. Of course they could be there for the > comment above, that is avoiding gziping the dir file, but couldn't > it be done more cleanly? OK. > > Why are the xsl and dtd files removed? I don't know. There's no reference in Changelog. > > in the install-info scriptlets, install-info should figure out whether > .gz is needed or not. OK. > > Having the dir file %config is not very nice, given that it is not > in sysconfdir. However I can't see any other way. Agree... with both sentences:) > > I suggest using %defattr(-,root,root,-) instead of %defattr(-,root,root) OK. > > > There is a build dependency loop texinfo -> ncurses-devel -> gpm-devel -> > install-info. > How do you suggest to change it? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review