https://bugzilla.redhat.com/show_bug.cgi?id=2275318 --- Comment #1 from Renich Bon Ciric <renich@xxxxxxxxxxxxxxxx> --- Here're a few coments: This package blocks 2275317 as well since it is a dependency of it. It seems that table.txt is not documentation but a file needed to rebuild table.go. It should not be marked as documentation IMHO, what do you think? > ## Add new characters > > 1. Edit `table.txt` file. > 2. Rebuild `table.go` file: > > ```go > go run ./make_table.go > ``` The license of the package seems to be the Apache License. IIUC, the appache indicates that a header be applied to every file as a comment: APPENDIX: How to apply the Apache License to your work. To apply the Apache License to your work, attach the following boilerplate notice, with the fields enclosed by brackets "{}" replaced with your own identifying information. (Don't include the brackets!) The text should be enclosed in the appropriate comment syntax for the file format. We also recommend that a file or class name and description of purpose be included on the same "printed page" as the copyright notice for easier identification within third-party archives. Copyright {yyyy} {name of copyright owner} Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at ... but none of the files do so. I don't know if this is OK but one should try and contact upstream and let them know about this, if you ask me. What do you think? A hidden file has been included: /usr/share/gocode/src/github.com/gosimple/unidecode/.goipath -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2275318 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202275318%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
