[Bug 2254918] Review Request: perl-Module-Build-Prereqs-FromCPANfile - Construct prereq parameters of Module::Build from cpanfile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2254918



--- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> ---
URL and Source0 addresses are Ok.
Source0 archive (SHA-512
29078020fb2638c9032cc28ca37caa12b530a6302be099dce437f89536dc5aae9aaacdecf42c6c7b2d41c40443eb03a8008855068f47ff203c75024e5175c8cd)
is original. Ok.
Summary verified from lib/Module/Build/Prereqs/FromCPANfile.pm. Ok.
Description verified from lib/Module/Build/Prereqs/FromCPANfile.pm. Ok.
License verified from Build.PL, README, and
lib/Module/Build/Prereqs/FromCPANfile.pm. Ok.
No XS code, noarch BuildArch is Ok.

FIX: Change 'perl(:VERSION) >= 5.14.0' to 'perl(:VERSION) >= 5.6.0'. The 5.14.0
value in tests is never compared against running perl. 5.6.0 is at Build.PL:1.

All tests pass. Ok.

$ rpmlint perl-Module-Build-Prereqs-FromCPANfile.spec
../SRPMS/perl-Module-Build-Prereqs-FromCPANfile-0.02-4.fc41.src.rpm
../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-4.fc41.noarch.rpm 
======================================== rpmlint session starts
=======================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

=== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0
badness; has taken 0.3 s ==
rpmlint is Ok.

$ rpm -q -lv -p
../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-4.fc41.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Mar  8 01:00
/usr/share/doc/perl-Module-Build-Prereqs-FromCPANfile
-rw-r--r--    1 root     root                      276 Aug 16  2014
/usr/share/doc/perl-Module-Build-Prereqs-FromCPANfile/Changes
-rw-r--r--    1 root     root                     1702 Aug 16  2014
/usr/share/doc/perl-Module-Build-Prereqs-FromCPANfile/README
-rw-r--r--    1 root     root                     1997 Mar  8 01:00
/usr/share/man/man3/Module::Build::Prereqs::FromCPANfile.3pm.gz
drwxr-xr-x    2 root     root                        0 Mar  8 01:00
/usr/share/perl5/vendor_perl/Module/Build/Prereqs
-rw-r--r--    1 root     root                     4359 Mar  8 01:00
/usr/share/perl5/vendor_perl/Module/Build/Prereqs/FromCPANfile.pm
File layout and permissions are Ok.
Note: Missing %{perl_vendorlib}/Module/Build path components will be provided
by perl-Module-Build which you will hard-require.

$ rpm -q --requires -p
../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-4.fc41.noarch.rpm |
sort -f | uniq -c 
      1 perl(CPAN::Meta::Prereqs) >= 2.132830
      1 perl(Exporter)
      1 perl(Module::CPANfile) >= 1.0000
      1 perl(strict)
      1 perl(version) >= 0.80
      1 perl(warnings)
      1 perl-libs
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
FIX: Run-require 'perl(Module::Build)'
(lib/Module/Build/Prereqs/FromCPANfile.pm:25).

$ rpm -q --recommends -p
../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-4.fc41.noarch.rpm |
sort -f | uniq -c 
      1 perl(Module::Build) >= 0.4004
Soft dependencies are Ok.

$ rpm -q --provides -p
../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-4.fc41.noarch.rpm |
sort -f | uniq -c 
      1 perl(Module::Build::Prereqs::FromCPANfile) = 0.02
      1 perl-Module-Build-Prereqs-FromCPANfile = 0.02-4.fc41
Binary provides are Ok.

$ resolvedeps rawhide
../RPMS/noarch/perl-Module-Build-Prereqs-FromCPANfile-0.02-4.fc41.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in Fedora 41
(https://koji.fedoraproject.org/koji/taskinfo?taskID=117192852). Ok.

Otherwise, the package is in line with Fedora and Perl packaging guidelines.

Please correct the FIX items and provide an updated spec file.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2254918

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254918%23c4
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux