https://bugzilla.redhat.com/show_bug.cgi?id=2009155 --- Comment #18 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Both of the issues mentioned by fedora-review are false-positives. +1 Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file license.png is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-oslo-messaging See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* Apache License", "Apache License 2.0". 119 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/python-oslo-messaging/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr, /usr/lib/python3.12/site-packages, /usr/share, /usr/share/licenses, /usr/lib, /usr/bin, /usr/lib/python3.12, /usr/share/doc [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/bin, /usr, /usr/lib/python3.12/site-packages, /usr/share, /usr/share/licenses, /usr/lib/python3.12, /usr/share/doc, /usr/lib [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 973 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [?]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-oslo-messaging , python3-oslo-messaging-tests [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: python3-oslo-messaging-14.7.0-2.fc41.noarch.rpm python-oslo-messaging-doc-14.7.0-2.fc41.noarch.rpm python3-oslo-messaging-tests-14.7.0-2.fc41.noarch.rpm python-oslo-messaging-14.7.0-2.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp09rh12t2')] checks: 32, packages: 4 python-oslo-messaging-doc.noarch: W: python-sphinx-doctrees-leftover /usr/share/doc/python-oslo-messaging-doc/html/.doctrees python3-oslo-messaging.noarch: W: python-leftover-require python3-amqp python3-oslo-messaging.noarch: W: python-leftover-require python3-cachetools python3-oslo-messaging.noarch: W: python-leftover-require python3-debtcollector python3-oslo-messaging.noarch: W: python-leftover-require python3-eventlet python3-oslo-messaging.noarch: W: python-leftover-require python3-futurist python3-oslo-messaging.noarch: W: python-leftover-require python3-kombu python3-oslo-messaging.noarch: W: python-leftover-require python3-oslo-config python3-oslo-messaging.noarch: W: python-leftover-require python3-oslo-log python3-oslo-messaging.noarch: W: python-leftover-require python3-oslo-metrics python3-oslo-messaging.noarch: W: python-leftover-require python3-oslo-middleware python3-oslo-messaging.noarch: W: python-leftover-require python3-oslo-serialization python3-oslo-messaging.noarch: W: python-leftover-require python3-oslo-service python3-oslo-messaging.noarch: W: python-leftover-require python3-oslo-utils python3-oslo-messaging.noarch: W: python-leftover-require python3-pbr python3-oslo-messaging.noarch: W: python-leftover-require python3-pyngus python3-oslo-messaging.noarch: W: python-leftover-require python3-stevedore python3-oslo-messaging.noarch: W: python-leftover-require python3-webob python3-oslo-messaging.noarch: W: python-leftover-require python3-yaml python3-oslo-messaging.noarch: W: no-manual-page-for-binary oslo-messaging-send-notification python3-oslo-messaging.noarch: W: no-manual-page-for-binary oslo-messaging-send-notification-3 python3-oslo-messaging-tests.noarch: W: no-documentation python-oslo-messaging-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-oslo-messaging-doc/html/.doctrees python-oslo-messaging-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-oslo-messaging-doc/html/.doctrees python-oslo-messaging-doc.noarch: W: files-duplicate /usr/share/doc/python-oslo-messaging-doc/html/_static/images/openstack-logo-full.png /usr/share/doc/python-oslo-messaging-doc/html/_static/images/logo-full.png python-oslo-messaging-doc.noarch: W: files-duplicate /usr/share/doc/python-oslo-messaging-doc/html/_static/images/openstack-logo-full.svg /usr/share/doc/python-oslo-messaging-doc/html/_static/images/logo-full.svg python-oslo-messaging-doc.noarch: W: files-duplicate /usr/share/doc/python-oslo-messaging-doc/html/_static/images/openstack-logo-vert.png /usr/share/doc/python-oslo-messaging-doc/html/_static/images/logo-vert.png python-oslo-messaging-doc.noarch: W: files-duplicate /usr/share/doc/python-oslo-messaging-doc/html/_static/images/openstack-logo-vert.svg /usr/share/doc/python-oslo-messaging-doc/html/_static/images/logo-vert.svg python-oslo-messaging-doc.noarch: W: description-shorter-than-summary 4 packages and 0 specfiles checked; 0 errors, 29 warnings, 15 filtered, 0 badness; has taken 0.7 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "python-oslo-messaging-doc". (none): E: there is no installed rpm "python3-oslo-messaging-tests". (none): E: there is no installed rpm "python3-oslo-messaging". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://releases.openstack.org/_static/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt : CHECKSUM(SHA256) this package : a4f619daa6f2f0d47c611fabc489cf634e55d2386bb4f92d2929d2c8aafef53e CHECKSUM(SHA256) upstream package : a4f619daa6f2f0d47c611fabc489cf634e55d2386bb4f92d2929d2c8aafef53e https://tarballs.openstack.org/oslo.messaging/oslo.messaging-14.7.0.tar.gz.asc : CHECKSUM(SHA256) this package : f4476aca6ccb49d89fb40dfd099310540c3ec32f0d6f2c9308f8b59d83ae92e2 CHECKSUM(SHA256) upstream package : f4476aca6ccb49d89fb40dfd099310540c3ec32f0d6f2c9308f8b59d83ae92e2 https://tarballs.openstack.org/oslo.messaging/oslo.messaging-14.7.0.tar.gz : CHECKSUM(SHA256) this package : 99bb6178f92370cb5d8d9d71e0ed918bf356e4f1e011abc7e1d7e0ce99cf33ad CHECKSUM(SHA256) upstream package : 99bb6178f92370cb5d8d9d71e0ed918bf356e4f1e011abc7e1d7e0ce99cf33ad Requires -------- python3-oslo-messaging (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3-amqp python3-cachetools python3-debtcollector python3-eventlet python3-futurist python3-kombu python3-oslo-config python3-oslo-log python3-oslo-metrics python3-oslo-middleware python3-oslo-serialization python3-oslo-service python3-oslo-utils python3-pbr python3-pyngus python3-stevedore python3-webob python3-yaml python-oslo-messaging-doc (rpmlib, GLIBC filtered): python3-oslo-messaging-tests (rpmlib, GLIBC filtered): python(abi) python3-oslo-config python3-oslo-messaging python3-oslo-middleware python3-oslo-serialization python3-oslo-service python3-oslo-utils python3-oslotest python3-stestr python3-testscenarios python3-testtools Provides -------- python3-oslo-messaging: python-oslo-messaging python3-oslo-messaging python3.12-oslo-messaging python3.12dist(oslo-messaging) python3dist(oslo-messaging) python-oslo-messaging-doc: python-oslo-messaging-doc python3-oslo-messaging-tests: python-oslo-messaging-tests python3-oslo-messaging-tests python3.12-oslo-messaging-tests Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-oslo-messaging --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: C/C++, Ocaml, Java, fonts, Haskell, R, Perl, PHP, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2009155 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202009155%23c18 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
