[Bug 2277710] Review Request: perl-Text-Lorem - Generate random Latin looking text

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2277710

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> ---
URL and Source0 addresses are Ok.
Source0 archive (SHA-512
c6d7f0e5dad59ce72bd86e84350a422f663289433508e125a592e6996a66578dfed50daa4904c7db76f6a90409673a2b2fcde9d660bb49e2e2efafeb887a0cfc)
is original. Ok.
Summary verified from lib/Text/Lorem.pm. Ok.
Description verified from lib/Text/Lorem.pm. Ok.
License verified from README, lib/Text/Lorem.pm, and Makefile.PL.
No XS code, noarch BuildArch is Ok.
All tests pass. Ok.

TODO: Consider running the tests in parallel by setting HARNESS_OPTIONS
variable.


$ rpmlint perl-Text-Lorem.spec ../SRPMS/perl-Text-Lorem-0.34-1.fc41.src.rpm
../RPMS/noarch/perl-Text-Lorem-0.34-1.fc41.noarch.rpm 
======================================== rpmlint session starts
=======================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

=== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0
badness; has taken 0.3 s ==
rpmlint is OK.

$ rpm -q -lv -p ../RPMS/noarch/perl-Text-Lorem-0.34-1.fc41.noarch.rpm 
-rwxr-xr-x    1 root     root                     1211 Apr 29 02:00
/usr/bin/lorem
drwxr-xr-x    2 root     root                        0 Apr 29 02:00
/usr/share/doc/perl-Text-Lorem
-rw-r--r--    1 root     root                      595 Feb 25  2021
/usr/share/doc/perl-Text-Lorem/CHANGES
-rw-r--r--    1 root     root                     1661 Feb 25  2021
/usr/share/doc/perl-Text-Lorem/README
-rw-r--r--    1 root     root                     1073 Apr 29 02:00
/usr/share/man/man1/lorem.1.gz
-rw-r--r--    1 root     root                     1592 Apr 29 02:00
/usr/share/man/man3/Text::Lorem.3pm.gz
-rw-r--r--    1 root     root                     4796 Feb 25  2021
/usr/share/perl5/vendor_perl/Text/Lorem.pm
FIX: Package %{perl_vendorlib}/Text directory.

$ rpm -q --requires -p ../RPMS/noarch/perl-Text-Lorem-0.34-1.fc41.noarch.rpm |
sort -f | uniq -c
      1 /usr/bin/perl
      1 perl(Getopt::Std)
      1 perl(strict)
      1 perl(Text::Lorem)
      1 perl(vars)
      1 perl(warnings)
      1 perl-libs
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary Requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Text-Lorem-0.34-1.fc41.noarch.rpm |
sort -f | uniq -c
      1 perl(Text::Lorem) = 0.34
      1 perl-Text-Lorem = 0.34-1.fc41
Binary Provides are Ok.

$ resolvedeps rawhide  ../RPMS/noarch/perl-Text-Lorem-0.34-1.fc41.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in Fedora 41
(https://koji.fedoraproject.org/koji/taskinfo?taskID=117068208). Ok.

Otherwise, the package is in line with Fedora and Perl packaging guidelines.
Please correct the FIX item and consider fixing the TODO item before building
this package.
Resolution: Package is APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2277710

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277710%23c2
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux