[Bug 1816301] Review Request: openfoam - computational fluid dynamics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1816301



--- Comment #48 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
Thanks for the updates. 

a) In the spec file, can you change
Prefix:         /usr/lib/openfoam
to
Prefix:         %{_libdir}/openfoam

See
https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/

b) Please also change
Release:        240429%{?dist}
to
Release:        1%{?dist}

This is used to indicate changes in the spec file, for example due to rebuilds
or changes
to other options when the sources are not changed.  It is independent of the
actual
release version of the sources.

c) In the files listing, please change

%{prefix}/%{projectDir}/COPYING
%{prefix}/%{projectDir}/README.md
%{prefix}/%{projectDir}/ThirdParty/README

to

%license %{prefix}/%{projectDir}/COPYING
%doc %{prefix}/%{projectDir}/README.md
%doc %{prefix}/%{projectDir}/ThirdParty/README

so that appropriate metainformation is added to the RPM package.

d) Is there any way to get wmake to mostly use Fedora specific build flags? See
https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#_macros_providing_compiler_and_linker_flags


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1816301

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201816301%23c48
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux