https://bugzilla.redhat.com/show_bug.cgi?id=2268124 --- Comment #17 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Tobias Florek from comment #15) > I honestly don't care. I am usually streched thin on time, but this package > won't need much maintenance. I am totally fine with co-maintainership as > well as you maintaining it. > > I have not diffed the spec, is there anything you find cleaner in yours? If > so, I would be glad if you can tell me, so I can learn. I package the same commit, but version it as a post-release snapshot of 2.2.0, which is more accurate since the 2.2.0 release “happened” even though there is a git tag. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots regarding snapshot versioning. I express the license as LicenseRef-Fedora-Public-Domain OR Unlicense and file https://gitlab.com/fedora/legal/fedora-license-data/-/issues/508, since the Unlicense was added as alternative to the original public-domain dedication rather than a replacement for it. I exclude i686 from the beginning under https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval, so I don’t need fix-build-on-odd-archs.patch. I run the tests (which your package attempts, but it reports "No tests were found!!!") I install the documentation in a noarch -doc subpackage. I attempt to support lnav users by packaging the lnav format support file in an -lnav subpackage, and use rich dependencies to make sure it is installed when lnav is (Requires: (loguru-lnav = %{version}-%{release} if lnav)). There are a few other small differences. I think all of Benson Muite’s feedback is addressed in my version. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2268124 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202268124%23c17 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
