https://bugzilla.redhat.com/show_bug.cgi?id=2274746 --- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Below is initial review of just SPEC file inspection and rpmlint output Issues: ======= - Header files in -devel subpackage, if present. Note: libschrift : /usr/include/schrift.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===> Read https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: libschrift. Illegal package name: libschrift. Does not provide -static: libschrift. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries ==> This package need to be fixed to generate dynamic library and not static library. - You don't need to write below line in SPEC ExclusiveArch: x86_64 aarch64 ppc64le s390x Package should be building on all arch unless known for specific reason - %description text should be aligned to 80 characters per line - You should write actual version and release values and not macros * Mon Mar 25 2024 Manish Tiwari <matiwari@xxxxxxxxxx> - %{version}-%{release} change to * Mon Mar 25 2024 Manish Tiwari <matiwari@xxxxxxxxxx> - 0.10.2-1 - Package must own all directories that it creates. Note: Directories without known owners: /usr/share/man, /usr/include, /usr/share/doc, /usr/share/licenses, /usr/share, /usr/lib, /usr ==> Your package should own the directories in which this package is installing files. Rpmlint ------- Checking: libschrift-0.10.2-1.fc41.x86_64.rpm libschrift-0.10.2-1.fc41.src.rpm ============================ rpmlint session starts ============================ libschrift.x86_64: E: static-library-without-debuginfo /usr/lib/libschrift.a libschrift.x86_64: E: standard-dir-owned-by-package /usr/share/man/man3 libschrift.spec:9: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 9) libschrift.spec:49: W: macro-in-%changelog %{version} libschrift.spec:49: W: macro-in-%changelog %{release} libschrift.x86_64: W: devel-file-in-non-devel-package /usr/include/schrift.h libschrift.x86_64: W: devel-file-in-non-devel-package /usr/lib/libschrift.a libschrift.src: E: description-line-too-long libschrift is a lightweight TrueType font rendering library that provides basic font rendering capabilities. It aims for simplicity and efficiency, making it suitable for various embedded and resource-constrained environments. libschrift.x86_64: E: description-line-too-long libschrift is a lightweight TrueType font rendering library that provides basic font rendering capabilities. It aims for simplicity and efficiency, making it suitable for various embedded and resource-constrained environments. 2 packages and 0 specfiles checked; 4 errors, 5 warnings, 9 filtered, 4 badness; has taken 0.2 s Fix above issues and submit new SRPM and SPEC by updating release to 2 and adding changelog about changes done in SPEC file -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2274746 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202274746%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
