https://bugzilla.redhat.com/show_bug.cgi?id=2245564 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(xavier@bachelot.o | |rg) | --- Comment #8 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- I was just triaging some bugs, this one was assigned but the fedora review flag was not properly set, thus I fixed that. Here are some preliminary notes: - Source URL is not in the correct format. Should be something alike : https://gitlab.com/OWNER/PROJECT/-/archive/%{gittag}/%{name}-%{version}.tar.gz See https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags - You should have both main package with the versioned so and a -devel subpackage with the headers and unversioned so. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages However, no versioned so are provided, there's an upstream bug about that already: https://github.com/azubieta/xdg-utils-cxx/issues/18 I think this might be fixed already in master branch, but not in a tag, so you might need to package a snapshot until upstream makes a proper release. But upstream seems inactive... -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2245564 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202245564%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
