https://bugzilla.redhat.com/show_bug.cgi?id=2274150 --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > %define __spec_install_post %{nil} > %define debug_package %{nil} > %define __os_install_post %{_dbpath}/brp-compress What's all this for? We shouldn't need any of this... > %global with_selinux 1 We do not need a conditional if it's always enabled, so drop it. > Requires: openssh >= 6.9.0, coreutils, openssh-server >= 6.9.0, openssl, curl, systemd > Requires(pre): glibc-common, shadow-utils, systemd, systemd-units > Requires(post): grep, coreutils, openssh-server >= 6.9.0, systemd, systemd-units > Requires(preun): systemd, systemd-units > Requires(postun): shadow-utils, systemd, systemd-units Please reformat this to have one dependency per line instead of listing them out like this. That makes it easier to recognize in diffs. > # Create/configure system user > %{_bindir}/getent passwd ec2-instance-connect || %{_sbindir}/useradd -r -M -s %{_sbindir}/nologin ec2-instance-connect > %{_sbindir}/usermod -L ec2-instance-connect This needs to be converted to sysusers. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/#_dynamic_allocation Additionally, all the scriptlets need to be rethought, we can't have scriptlets modifying things like this when drop-in files can be shipped in subpackages or whatnot. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2274150 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202274150%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
