https://bugzilla.redhat.com/show_bug.cgi?id=2264277 Michel Lind <michel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michel@xxxxxxxxxxxxxxx --- Comment #22 from Michel Lind <michel@xxxxxxxxxxxxxxx> --- Hi Benson, Hope these notes might address some of the points you raised. Looks like Jordan already addressed most of the rest. > Comments: > a) Is it possible to add a patch so that Cargo is not required. Probably > affects: > https://github.com/sched-ext/scx/blob/main/meson.build#L23 > https://github.com/sched-ext/scx/blob/main/meson.build#L110-L155 Cargo is not required in this build; there is a separate https://crates.io/crates/scx_utils for the Rust component. The meson build script just supports building all of them together but the Cargo dependency is optional > b) The spec file packaged with the rpm has LGPL-2.1 instead of LGPL-2.1-only the bundled libbpf ships that file: https://github.com/libbpf/libbpf/blob/6d3595d215b014d3eddb88038d686e1c20781534/LICENSE.LGPL-2.1 and per https://spdx.org/licenses/LGPL-2.1.html that translates to LGPL 2.1 only (which is LGPL-2.1-only in the new SPDX version, see https://docs.fedoraproject.org/en-US/legal/allowed-licenses/) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2264277 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202264277%23c22 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
