https://bugzilla.redhat.com/show_bug.cgi?id=2274948 --- Comment #2 from Davide Cavalca <davide@xxxxxxxxxxxx> --- [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "Boost Software License 1.0", "*No copyright* MIT License", "MIT License and/or The Unlicense". 48 files have unknown license. Detailed output of licensecheck in /tmp/2274948-openxr-explorer/licensecheck.txt You need to declare src/openxrexplorer/imgui as bundled library (it's a copy of https://github.com/ocornut/imgui). cmake/FindOpenXR.cmake is under BSL-1.0. [!]: Package contains desktop file if it is a GUI application. This might not be an issue as this is more of a debugging/testing tool than an end user app. I would also consider packaging CPM separately and including it as a BR, but I won't block the review on it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2274948 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202274948%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
