https://bugzilla.redhat.com/show_bug.cgi?id=2275304 Miroslav Suchý <msuchy@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |msuchy@xxxxxxxxxx --- Comment #2 from Miroslav Suchý <msuchy@xxxxxxxxxx> --- > Source: openscanhub-1.0.0.tar.gz Can you put there either a full URL or comment on how you fetched the tarball? > %defattr(644,root,root,755) This is the default. You can remove it. > %{_unitdir}/osh-retention.* > %{_unitdir}/osh-stats.* Do you really want to have this set to root:apache? ># record timestamp >echo -n '>>> ' >date -R This looks like development stuff. Definitely should not be in final rpm. ># this only takes an effect if PostgreSQL is running and the database exists >pg_isready -h localhost && %{python3_sitelib}/osh/hub/manage.py migrate This is a discouraged practice. You never know how big the DB is. I saw migration that lasted several hours. You do not want to block rpm upgrades because of db upgrade. Or even worse, fail because of that. This should be separate step, outside of rpm. >Provides: covscan-client = %{version} >Obsoletes: covscan-client < %{version} >Conflicts: covscan-client < %{version} Provides and Obsoletes are OK. Then you do not need Conflicts. All descriptions in %description should end with dot. And I believe you can be slightly more verbose there. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2275304 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202275304%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
