https://bugzilla.redhat.com/show_bug.cgi?id=2254919 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source0 archive (SHA-512: 2caee1d899077feb7fef6bb37186886a14372f93324e2c904aa81829e39d2d123101fd02931ef0312b90630b9fc39cc566083cce12eed8360d569a01076369ac) is original. Ok. FIX: Use better summary, e.g. a line from lib/MooX/Role/EventEmitter.pm "Event emitter role". FIX: Append a full stop to the description text. License verified from Makefile.PL. Ok. No XS code, noarch BuildArch is Ok. TODO: Do not build-require 'perl(Pod::Markdown)' because it's not helpful. While the module is uses when executing Makefile.PL, it's only purpose is to regenerate README.md that we do not package or use in any other way. Because a use of the module guarded with eval {} block, an exception from a failed load is ignored. All tests pass. Ok. $ rpmlint perl-MooX-Role-EventEmitter.spec ../SRPMS/perl-MooX-Role-EventEmitter-0.04-4.fc41.src.rpm ../RPMS/noarch/perl-MooX-Role-EventEmitter-0.04-4.fc41.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-MooX-Role-EventEmitter.noarch: W: description-shorter-than-summary perl-MooX-Role-EventEmitter.src: W: description-shorter-than-summary === 2 packages and 1 specfiles checked; 0 errors, 2 warnings, 6 filtered, 0 badness; has taken 0.3 s == FIX: Rephrase the summary. $ rpm -q -lv -p ../RPMS/noarch/perl-MooX-Role-EventEmitter-0.04-4.fc41.noarch.rpm drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/doc/perl-MooX-Role-EventEmitter -rw-r--r-- 1 root root 264 Jul 22 2023 /usr/share/doc/perl-MooX-Role-EventEmitter/Changes -rw-r--r-- 1 root root 506 Jul 22 2023 /usr/share/doc/perl-MooX-Role-EventEmitter/README -rw-r--r-- 1 root root 1416 Mar 8 01:00 /usr/share/man/man3/MooX::Role::EventEmitter.3pm.gz drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/perl5/vendor_perl/MooX drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/perl5/vendor_perl/MooX/Role -rw-r--r-- 1 root root 2780 Jul 22 2023 /usr/share/perl5/vendor_perl/MooX/Role/EventEmitter.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-MooX-Role-EventEmitter-0.04-4.fc41.noarch.rpm | sort -f | uniq -c 1 perl(:VERSION) >= 5.20.0 1 perl(Carp) 1 perl(feature) 1 perl(Moo::Role) >= 2 1 perl(Scalar::Util) 1 perl(Try::Tiny) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-MooX-Role-EventEmitter-0.04-4.fc41.noarch.rpm | sort -f | uniq -c 1 perl(MooX::Role::EventEmitter) = 0.04 1 perl-MooX-Role-EventEmitter = 0.04-4.fc41 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-MooX-Role-EventEmitter-0.04-4.fc41.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=116491504). Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Please correct the FIX items and consider fixing the TODO item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2254919 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254919%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
