https://bugzilla.redhat.com/show_bug.cgi?id=2254920 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Petr Pisar <ppisar@xxxxxxxxxx> --- > I am trying to learn from what you find so you don't have to keep finding it - I guess I'm still not quite there. :) Not a problem. You are getting better. Changes in the spec file: --- perl-Net-Async-WebSocket.spec.old 2024-03-08 01:00:00.000000000 +0100 +++ perl-Net-Async-WebSocket.spec 2024-04-15 02:00:00.000000000 +0200 @@ -1,6 +1,6 @@ Name: perl-Net-Async-WebSocket Version: 0.13 -Release: 4%{?dist} +Release: 5%{?dist} Summary: Use WebSockets with IO::Async License: GPL-1.0-or-later OR Artistic-1.0-Perl URL: https://metacpan.org/dist/Net-Async-WebSocket @@ -13,7 +13,6 @@ BuildRequires: perl(IO::Async::Loop) BuildRequires: perl(IO::Async::Notifier) >= 0.63 BuildRequires: perl(IO::Async::OS) -BuildRequires: perl(IO::Async::SSL) BuildRequires: perl(IO::Async::Stream) >= 0.34 BuildRequires: perl(IO::Async::Test) BuildRequires: perl(IO::Socket::INET) @@ -27,14 +26,18 @@ BuildRequires: perl(Test::More) >= 0.88 BuildRequires: perl(Test::Pod) >= 1.00 BuildRequires: perl(URI) -BuildRequires: perl(URI::_server) BuildRequires: perl(URI::wss) BuildRequires: perl(base) BuildRequires: perl(strict) BuildRequires: perl(warnings) # some runtime deps are missed/are optional Recommends: perl(IO::Async::SSL) +Requires: perl(Protocol::WebSocket) >= 0.22 Requires: perl(URI::wss) +# version some deps +Requires: perl(IO::Async::Listener) >= 0.61 +Requires: perl(IO::Async::Stream) >= 0.34 +%global __requires_exclude ^perl\\(IO::Async::(Listener|Stream)\\)$ %description This distribution provides modules that implement the WebSocket protocol, @@ -57,10 +60,13 @@ %files %doc Changes examples README %license LICENSE -%{perl_vendorlib}/Net/Async/WebSocket* +%{perl_vendorlib}/Net %{_mandir}/man3/Net::Async::WebSocket* %changelog +* Mon Apr 15 2024 Chris Adams <linux@xxxxxxxxxxx> 0.13-5 +- additional spec file cleanups + * Fri Mar 08 2024 Chris Adams <linux@xxxxxxxxxxx> 0.13-4 - additional spec file cleanups > +%global __requires_exclude ^perl\\(IO::Async::(Listener|Stream)\\)$ TODO: I recommend appending the regular expression with "%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(..." because it does not discards excludes defined in system-wide macros. $ rpmlint perl-Net-Async-WebSocket.spec ../SRPMS/perl-Net-Async-WebSocket-0.13-5.fc41.src.rpm ../RPMS/noarch/perl-Net-Async-WebSocket-0.13-5.fc41.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 === 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.3 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Net-Async-WebSocket-0.13-5.fc41.noarch.rpm drwxr-xr-x 2 root root 0 Apr 15 02:00 /usr/share/doc/perl-Net-Async-WebSocket -rw-r--r-- 1 root root 2543 Oct 11 2018 /usr/share/doc/perl-Net-Async-WebSocket/Changes -rw-r--r-- 1 root root 602 Oct 11 2018 /usr/share/doc/perl-Net-Async-WebSocket/README drwxr-xr-x 2 root root 0 Oct 11 2018 /usr/share/doc/perl-Net-Async-WebSocket/examples -rw-r--r-- 1 root root 521 Oct 11 2018 /usr/share/doc/perl-Net-Async-WebSocket/examples/echo-server.pl -rw-r--r-- 1 root root 766 Oct 11 2018 /usr/share/doc/perl-Net-Async-WebSocket/examples/stdio-client.pl drwxr-xr-x 2 root root 0 Apr 15 02:00 /usr/share/licenses/perl-Net-Async-WebSocket -rw-r--r-- 1 root root 18418 Oct 11 2018 /usr/share/licenses/perl-Net-Async-WebSocket/LICENSE -rw-r--r-- 1 root root 1117 Apr 15 02:00 /usr/share/man/man3/Net::Async::WebSocket.3pm.gz -rw-r--r-- 1 root root 1714 Apr 15 02:00 /usr/share/man/man3/Net::Async::WebSocket::Client.3pm.gz -rw-r--r-- 1 root root 2114 Apr 15 02:00 /usr/share/man/man3/Net::Async::WebSocket::Protocol.3pm.gz -rw-r--r-- 1 root root 1688 Apr 15 02:00 /usr/share/man/man3/Net::Async::WebSocket::Server.3pm.gz drwxr-xr-x 2 root root 0 Apr 15 02:00 /usr/share/perl5/vendor_perl/Net drwxr-xr-x 2 root root 0 Apr 15 02:00 /usr/share/perl5/vendor_perl/Net/Async drwxr-xr-x 2 root root 0 Apr 15 02:00 /usr/share/perl5/vendor_perl/Net/Async/WebSocket -rw-r--r-- 1 root root 926 Apr 15 02:00 /usr/share/perl5/vendor_perl/Net/Async/WebSocket.pm -rw-r--r-- 1 root root 4657 Apr 15 02:00 /usr/share/perl5/vendor_perl/Net/Async/WebSocket/Client.pm -rw-r--r-- 1 root root 5832 Apr 15 02:00 /usr/share/perl5/vendor_perl/Net/Async/WebSocket/Protocol.pm -rw-r--r-- 1 root root 3792 Apr 15 02:00 /usr/share/perl5/vendor_perl/Net/Async/WebSocket/Server.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Net-Async-WebSocket-0.13-5.fc41.noarch.rpm | sort -f | uniq -c 1 perl(:VERSION) >= 5.10.0 1 perl(base) 1 perl(Carp) 1 perl(IO::Async::Listener) >= 0.61 1 perl(IO::Async::Stream) >= 0.34 1 perl(Net::Async::WebSocket::Protocol) 1 perl(Protocol::WebSocket) >= 0.22 1 perl(Protocol::WebSocket::Frame) 1 perl(Protocol::WebSocket::Handshake::Client) 1 perl(Protocol::WebSocket::Handshake::Server) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Sub::Util) >= 1.40 1 perl(URI) 1 perl(URI::wss) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Net-Async-WebSocket-0.13-5.fc41.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=116447104). OK. Please consider fixing the TODO item before building this package. This package is APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2254920 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254920%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
