https://bugzilla.redhat.com/show_bug.cgi?id=2274950 Davide Cavalca <davide@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #6 from Davide Cavalca <davide@xxxxxxxxxxxx> --- Thanks, looks good now, this is APPROVED. > I've not done bundled provides yet, but will need to do for a handful of the XR SIG packages. What is the best way to determine the bundling and version numbers? Googling the filename and/or some of its content (e.g. a function definition) is usually enough to find where it's from, if the header doesn't state it outright. I generally leave the version out if it can't be determined (i.e. just declare Provides: bundled(KTX-Software) and add a comment before mentioning the files/paths that are actually bundled and the license). > Also, quickly looking at KTX-Software I'm not sure if it's actually bundled. Maybe a copy-paste of some interface stuff from 4 years ago, but I'd count this as part of xrgears at this point. https://gitlab.freedesktop.org/monado/demos/xrgears/-/blob/master/src/ktx_stream.c matches pretty closely to https://github.com/KhronosGroup/KTX-Software/blob/main/lib/memstream.c modulo some comments, I assume the others will be similar. IMO in this case it's worth declaring as bundled and leaving it at that (it's modified and deeply entrenched into xrgears, so not much point into attempting to unbundle). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2274950 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202274950%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
