https://bugzilla.redhat.com/show_bug.cgi?id=2273535 --- Comment #5 from Neal Gompa <ngompa13@xxxxxxxxx> --- Err... > %dir %{_sysconfdir}/bash_completion.d > %{_sysconfdir}/bash_completion.d/vdostats This is the wrong place to install bash completion files. It should be installed into "%{bash_completions_dir}" Also, don't co-own the completions directory. > %license %{_defaultdocdir}/%{name}/COPYING The license should not be in the docdir, but instead in the licensedir... > %{_bindir}/adaptLVMVDO.sh This should not be here. Either this is a normal command style file (thus no .sh) or it is a script file that is intended to be sourced and doesn't belong here. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2273535 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202273535%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
