https://bugzilla.redhat.com/show_bug.cgi?id=2273535 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Some notes: > - This is my first Fedora package and as such, I will need a sponsor. If you haven't got a sponsor yet, let's talk, as I am able to do so. > - I will be on PTO April 8th through the 19th, delaying response time. Any urgent issues can be directed to vdo-internal@xxxxxxxxxx. This is absolutely not an acceptable statement to make. This is predicated on an assumption that only Red Hatters will be interacting in a review. All package reviews are public and intended to be communicated in a tracked manner for the purposes of understanding package evolution and for educating future packagers. In the future, please make every effort to avoid leveraging Red Hat-internal channels for Fedora work. Intiial spec review: > ## START: Set by rpmautospec > ## (rpmautospec version 0.6.3) > ## RPMAUTOSPEC: autorelease > %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: > release_number = 1; > base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); > print(release_number + base_release_number - 1); > }%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} > ## END: Set by rpmautospec Drop this whole thing from your spec file. > %global commit e7a687da9e25d563838a6d2f4ca5036c80033ceb > %global gittag 8.2.2.2 > %global shortcommit %(c=%{commit}; echo ${c:0:7}) Drop all this and just set "Version: 8.2.2.2" instead. > Source0: %{url}/archive/%{commit}/%{name}-%{shortcommit}.tar.gz Replace "%{commit}" and "%{shortcommit}" with "%{version}" > Release: %autorelease Since you have a changelog section with changelog entries, you should not use "%autorelease" and instead should use the normal convention. > %setup -q -n %{name}-%{commit} > %patch 0001 -p1 You can replace this with "%autosetup -p1" > make %{?_smp_mflags} Use "%make_build" instead. > make install DESTDIR=$RPM_BUILD_ROOT INSTALLOWNER= name=%{name} \ > bindir=%{_bindir} defaultdocdir=%{_defaultdocdir} libexecdir=%{_libexecdir} \ > mandir=%{_mandir} presetdir=%{_presetdir} \ > python3_sitelib=/%{python3_sitelib} sysconfdir=%{_sysconfdir} \ > unitdir=%{_unitdir} Use the following instead: > %make_install INSTALLOWNER= name=%{name} \ > bindir=%{_bindir} defaultdocdir=%{_defaultdocdir} libexecdir=%{_libexecdir} \ > mandir=%{_mandir} presetdir=%{_presetdir} \ > python3_sitelib=/%{python3_sitelib} sysconfdir=%{_sysconfdir} \ > unitdir=%{_unitdir} (As an aside, seriously consider modernizing your Makefiles or switching to something like CMake or Meson, which can determine these settings for you automatically.) Additional spec notes: * The spec file formatting is wrong. The subpackages should be grouped together rather than split between the package build sections. A couple of examples of good spec file structures: * btrfs-progs: https://src.fedoraproject.org/rpms/btrfs-progs/blob/rawhide/f/btrfs-progs.spec * bcachefs-progs: https://src.fedoraproject.org/rpms/bcachefs-tools/blob/rawhide/f/bcachefs-tools.spec * You only need "ExcludeArch: i686" once, and it should be "ExcludeArch: %{ix86}". -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2273535 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202273535%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
