https://bugzilla.redhat.com/show_bug.cgi?id=2254920 --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source0 archive (SHA-512 fa9d35f98fced11c7c5f63637d7fc77d52ac5ba44e33dba2df510b470e2c9c440591f537654b9a7e49360ea207c60cae57ea9558460b91ccf4bdba34199d092b) is original. Ok. Summary verified from lib/Net/Async/WebSocket.pm. Ok. Documentation verified from lib/Net/Async/WebSocket.pm. Ok. License verified from Build.PL, LICENSE, lib/Net/Async/WebSocket.pm, lib/Net/Async/WebSocket/Client.pm, lib/Net/Async/WebSocket/Protocol.pm, lib/Net/Async/WebSocket/Server.pm. Ok. No XS code, noarch BuildArch is Ok. FIX: Do not depend on 'perl(URI::_server)'. It is a fallback if 'perl(URI::wss)' is not available, but you already depend on 'perl(URI::wss)' (lib/Net/Async/WebSocket/Client.pm:22). FIX: Do not build-require 'perl(IO::Async::SSL)'. It's not used at tests. All tests pass. Ok. $ rpmlint perl-Net-Async-WebSocket.spec ../SRPMS/perl-Net-Async-WebSocket-0.13-4.fc41.src.rpm ../RPMS/noarch/perl-Net-Async-WebSocket-0.13-4.fc41.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 === 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.3 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Net-Async-WebSocket-0.13-4.fc41.noarch.rpm drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/doc/perl-Net-Async-WebSocket -rw-r--r-- 1 root root 2543 Oct 11 2018 /usr/share/doc/perl-Net-Async-WebSocket/Changes -rw-r--r-- 1 root root 602 Oct 11 2018 /usr/share/doc/perl-Net-Async-WebSocket/README drwxr-xr-x 2 root root 0 Oct 11 2018 /usr/share/doc/perl-Net-Async-WebSocket/examples -rw-r--r-- 1 root root 521 Oct 11 2018 /usr/share/doc/perl-Net-Async-WebSocket/examples/echo-server.pl -rw-r--r-- 1 root root 766 Oct 11 2018 /usr/share/doc/perl-Net-Async-WebSocket/examples/stdio-client.pl drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/licenses/perl-Net-Async-WebSocket -rw-r--r-- 1 root root 18418 Oct 11 2018 /usr/share/licenses/perl-Net-Async-WebSocket/LICENSE -rw-r--r-- 1 root root 1117 Mar 8 01:00 /usr/share/man/man3/Net::Async::WebSocket.3pm.gz -rw-r--r-- 1 root root 1716 Mar 8 01:00 /usr/share/man/man3/Net::Async::WebSocket::Client.3pm.gz -rw-r--r-- 1 root root 2115 Mar 8 01:00 /usr/share/man/man3/Net::Async::WebSocket::Protocol.3pm.gz -rw-r--r-- 1 root root 1686 Mar 8 01:00 /usr/share/man/man3/Net::Async::WebSocket::Server.3pm.gz drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/perl5/vendor_perl/Net/Async/WebSocket -rw-r--r-- 1 root root 926 Mar 8 01:00 /usr/share/perl5/vendor_perl/Net/Async/WebSocket.pm -rw-r--r-- 1 root root 4657 Mar 8 01:00 /usr/share/perl5/vendor_perl/Net/Async/WebSocket/Client.pm -rw-r--r-- 1 root root 5832 Mar 8 01:00 /usr/share/perl5/vendor_perl/Net/Async/WebSocket/Protocol.pm -rw-r--r-- 1 root root 3792 Mar 8 01:00 /usr/share/perl5/vendor_perl/Net/Async/WebSocket/Server.pm FIX: Own %{perl_vendorlib}/Net and %{perl_vendorlib}/Net/Async directories. $ rpm -q --requires -p ../RPMS/noarch/perl-Net-Async-WebSocket-0.13-4.fc41.noarch.rpm | sort -f | uniq -c 1 perl(:VERSION) >= 5.10.0 1 perl(base) 1 perl(Carp) 1 perl(IO::Async::Listener) 1 perl(IO::Async::Stream) 1 perl(Net::Async::WebSocket::Protocol) 1 perl(Protocol::WebSocket::Frame) 1 perl(Protocol::WebSocket::Handshake::Client) 1 perl(Protocol::WebSocket::Handshake::Server) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Sub::Util) >= 1.40 1 perl(URI) 1 perl(URI::wss) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: Constrain 'perl(IO::Async::Listener)' with '>= 0.61' (Build.PL:12). TODO: Constrain 'perl(IO::Async::Stream)' with '>= 0.34' (Build.PL:14). TODO: Run-require 'perl(Protocol::WebSocket) >= 0.22' or 'perl-Protocol-WebSocket >= 0.22' (Build.PL:15). It's not directly used, but it's the only versioned module from perl-Protocol-WebSocket package which provides used perl(Protocol::WebSocket::Frame). $ rpm -q --recommends -p ../RPMS/noarch/perl-Net-Async-WebSocket-0.13-4.fc41.noarch.rpm | sort -f | uniq -c 1 perl(IO::Async::SSL) Binary recommends are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Net-Async-WebSocket-0.13-4.fc41.noarch.rpm | sort -f | uniq -c 1 perl(Net::Async::WebSocket) = 0.13 1 perl(Net::Async::WebSocket::Client) = 0.13 1 perl(Net::Async::WebSocket::Protocol) = 0.13 1 perl(Net::Async::WebSocket::Server) = 0.13 1 perl-Net-Async-WebSocket = 0.13-4.fc41 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Net-Async-WebSocket-0.13-4.fc41.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=116392900). Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Please correct all FIX items, consider fixing TODO items and provide an updates spec file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2254920 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254920%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
