https://bugzilla.redhat.com/show_bug.cgi?id=2275018 Jordan Rome <jordan@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value --- Comment #2 from Jordan Rome <jordan@xxxxxxxxxxxxxx> --- https://bugzilla.redhat.com/show_bug.cgi?id=2264277 Comments from this review: Comments: a) Is it possible to add a patch so that Cargo is not required. Probably affects: https://github.com/sched-ext/scx/blob/main/meson.build#L23 https://github.com/sched-ext/scx/blob/main/meson.build#L110-L155 - Removed Cargo from BuildRequires b) The spec file packaged with the rpm has LGPL-2.1 instead of LGPL-2.1-only Rpm should now be updated with LGPL-2.1-only c) Not directly related to this review, but might a bpf SIG be a reasonable thing to have to update all bpf packages at once so that bundling is reduced? There exists one already apparently. d) Should BREAKING_CHANGES.md and OVERVIEW.md also be packaged? Added these readmes as well as INSTALL.md e) Is it possible to run a smoke check for each binary, for example ./scx_simple -h This is not possible without a custom kernel with sched_ext: https://github.com/sched-ext/scx/blob/main/INSTALL.md f) Helpful to list all the binaries, though a preference not a requirement Where do I do this? g) Using %exclude is not recommended, better to patch out or use sed to remove: https://github.com/sched-ext/scx/blob/main/meson.build#L170-L174 Removed the %excludes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2275018 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202275018%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
