Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Megazeux - Text-character driven game creation system https://bugzilla.redhat.com/show_bug.cgi?id=427718 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-01-21 13:15 EST ------- Hello. I just glanced at your spec file but it seems there are not a few issues to be fixed. For general packaging guidelines you can refer to: http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines * Please make summary more easy to grasp. * Please consider to use disttag. http://fedoraproject.org/wiki/Packaging/DistTag * Don't use Epoch unless necessary. * Source must be given with full URL. http://fedoraproject.org/wiki/Packaging/SourceURL * Please explain why you limit the BuildArch to only i386. * Remove "Vendor" and "Distribution" * BuildRoot tag does not meet Fedora packaging guidelines * gcc is redundant for BuildRequires * I guess all Requires you are writing now are not needed and should be removed. rpmbuild checks the dependency for libraries and adds the detected requires automatically to binary rpms. * Please make sure that fedora specific compilaton flags are correctly honored. - Also, please make build log more verbose so that we can easily check if compilation flags are correctly used - Stripping binaries by yourself (or by "make" process") is forbidden to create debuginfo rpm correctly. * Please support parallel make if possible. * To keep timestamps, please add "-p" option when using "cp" or "install" commands. * Don't fix owners/permission on %post. This must be done by %install ends, or if it can't this must be treated by appropriate %attr in %files. * Would you explain why you don't want %config(noreplace)? * We now recommend %defattr(-,root,root,-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review