https://bugzilla.redhat.com/show_bug.cgi?id=2243131 --- Comment #17 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU General Public License, Version 3", "Creative Commons Attribution-ShareAlike 4.0", "Creative Commons Attribution-ShareAlike 4.0 and/or GNU General Public License, Version 3", "*No copyright* Creative Commons Attribution-ShareAlike 4.0 and/or Creative Commons CC0 1.0 and/or GNU General Public License v3.0 or later and/or SIL Open Font License", "Unknown or generated", "*No copyright* Creative Commons Attribution-ShareAlike 4.0", "*No copyright* Creative Commons CC0 1.0", "*No copyright* SIL Open Font License 1.1", "SIL Open Font License 1.1 with Reserved Font Name", "Creative Commons CC0 1.0". 257 files have unknown license. Detailed output of licensecheck in /home/fedora/2243131-metadata-cleaner/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/help/ko, /usr/share/help/nb_NO, /usr/share/help/fr, /usr/share/help/pt, /usr/share/dbus-1, /usr/share/help/zh_TW, /usr/share/help/eu, /usr/share/glib-2.0, /usr/share/icons/hicolor/scalable/apps, /usr/share/help/el, /usr/share/help/ro, /usr/share/help/lt, /usr/share/help/bn, /usr/share/help/nl, /usr/share/help/de, /usr/share/help/uk, /usr/share/help/gl, /usr/share/help/ta, /usr/share/help/ru, /usr/share/glib-2.0/schemas, /usr/share/help/pt_BR, /usr/share/help/id, /usr/share/icons/hicolor, /usr/share/help/es, /usr/share/help/tr, /usr/share/dbus-1/services, /usr/share/help/ca, /usr/share/icons/hicolor/symbolic/apps, /usr/share/help/da, /usr/share/help/sv, /usr/share/help/fy, /usr/share/help/ja, /usr/share/help/az, /usr/share/help/hu, /usr/share/icons/hicolor/scalable, /usr/share/help/oc, /usr/share/help/hr, /usr/share/help/nn, /usr/share/icons/hicolor/symbolic, /usr/share/help/cs, /usr/share/help/pl, /usr/share/help/ar, /usr/share/help/it, /usr/share/help/zh_CN, /usr/share/help/sr, /usr/share/help/ur, /usr/share/help/fi, /usr/share/help/C, /usr/share/help/eo [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/help/ko, /usr/share/help/nb_NO, /usr/share/help/ca, /usr/share/help/fr, /usr/share/help/da, /usr/share/help/fy, /usr/share/help/sv, /usr/share/help/pt, /usr/share/help/zh_TW, /usr/share/help/ja, /usr/share/help/eu, /usr/share/help/el, /usr/share/help/az, /usr/share/help/hu, /usr/share/help/ro, /usr/share/help/lt, /usr/share/help/bn, /usr/share/help/nl, /usr/share/help/de, /usr/share/help/oc, /usr/share/help/hr, /usr/share/help/nn, /usr/share/help/gl, /usr/share/help/uk, /usr/share/help/cs, /usr/share/help/pl, /usr/share/help/ar, /usr/share/help/it, /usr/share/help/zh_CN, /usr/share/help/ta, /usr/share/help/ru, /usr/share/help/sr, /usr/share/help/ur, /usr/share/help/fi, /usr/share/help/pt_BR, /usr/share/help/id, /usr/share/help/es, /usr/share/help/tr, /usr/share/help/C, /usr/share/help/eo [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 18134 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: metadata-cleaner-2.5.4-0.fc41.noarch.rpm metadata-cleaner-langpacks-2.5.4-0.fc41.noarch.rpm metadata-cleaner-2.5.4-0.fc41.src.rpm ========================================= rpmlint session starts ======================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpth710ihd')] checks: 32, packages: 3 metadata-cleaner-langpacks.noarch: W: package-with-huge-docs 91% metadata-cleaner.noarch: W: no-manual-page-for-binary metadata-cleaner metadata-cleaner-langpacks.noarch: E: files-duplicated-waste 250257 metadata-cleaner.noarch: W: files-duplicate /usr/share/metadata-cleaner/src/metadatacleaner/ui/__init__.py /usr/share/metadata-cleaner/src/metadatacleaner/__init__.py:/usr/share/metadata-cleaner/src/metadatacleaner/modules/__init__.py metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/zh_TW/fr.romainvigier.MetadataCleaner/figures/add-files-button.png /usr/share/help/C/fr.romainvigier.MetadataCleaner/figures/add-files-button.png:/usr/share/help/da/fr.romainvigier.MetadataCleaner/figures/add-files-button.png:/usr/share/help/nb_NO/fr.romainvigier.MetadataCleaner/figures/add-files-button.png:/usr/share/help/nn/fr.romainvigier.MetadataCleaner/figures/add-files-button.png metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/zh_TW/fr.romainvigier.MetadataCleaner/figures/add-folders-button.png /usr/share/help/C/fr.romainvigier.MetadataCleaner/figures/add-folders-button.png:/usr/share/help/da/fr.romainvigier.MetadataCleaner/figures/add-folders-button.png:/usr/share/help/nb_NO/fr.romainvigier.MetadataCleaner/figures/add-folders-button.png:/usr/share/help/nn/fr.romainvigier.MetadataCleaner/figures/add-folders-button.png metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/zh_TW/fr.romainvigier.MetadataCleaner/figures/clean-button.png /usr/share/help/C/fr.romainvigier.MetadataCleaner/figures/clean-button.png metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/zh_TW/fr.romainvigier.MetadataCleaner/figures/icon.svg /usr/share/help/C/fr.romainvigier.MetadataCleaner/figures/icon.svg:/usr/share/help/ar/fr.romainvigier.MetadataCleaner/figures/icon.svg:/usr/share/help/az/fr.romainvigier.MetadataCleaner/figures/icon.svg:/usr/share/help/bn/fr.romainvigier.MetadataCleaner/figures/icon.svg:/usr/share/help/ca/fr.romainvigier.MetadataCleaner/figures/icon.svg:(and 34 more) metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/zh_TW/fr.romainvigier.MetadataCleaner/figures/metadata-example.png /usr/share/help/C/fr.romainvigier.MetadataCleaner/figures/metadata-example.png metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/nb_NO/fr.romainvigier.MetadataCleaner/figures/clean-button.png /usr/share/help/da/fr.romainvigier.MetadataCleaner/figures/clean-button.png metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/pt_BR/fr.romainvigier.MetadataCleaner/figures/clean-button.png /usr/share/help/gl/fr.romainvigier.MetadataCleaner/figures/clean-button.png:/usr/share/help/pt/fr.romainvigier.MetadataCleaner/figures/clean-button.png metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/pt_BR/fr.romainvigier.MetadataCleaner/figures/add-folders-button.png /usr/share/help/pt/fr.romainvigier.MetadataCleaner/figures/add-folders-button.png metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/pt_BR/fr.romainvigier.MetadataCleaner/figures/metadata-example.png /usr/share/help/pt/fr.romainvigier.MetadataCleaner/figures/metadata-example.png === 3 packages and 0 specfiles checked; 1 errors, 12 warnings, 11 filtered, 1 badness; has taken 0.6 s == Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 metadata-cleaner-langpacks.noarch: W: package-with-huge-docs 91% metadata-cleaner.noarch: W: no-manual-page-for-binary metadata-cleaner metadata-cleaner-langpacks.noarch: E: files-duplicated-waste 250257 metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/zh_TW/fr.romainvigier.MetadataCleaner/figures/add-files-button.png /usr/share/help/C/fr.romainvigier.MetadataCleaner/figures/add-files-button.png:/usr/share/help/da/fr.romainvigier.MetadataCleaner/figures/add-files-button.png:/usr/share/help/nb_NO/fr.romainvigier.MetadataCleaner/figures/add-files-button.png:/usr/share/help/nn/fr.romainvigier.MetadataCleaner/figures/add-files-button.png metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/zh_TW/fr.romainvigier.MetadataCleaner/figures/add-folders-button.png /usr/share/help/C/fr.romainvigier.MetadataCleaner/figures/add-folders-button.png:/usr/share/help/da/fr.romainvigier.MetadataCleaner/figures/add-folders-button.png:/usr/share/help/nb_NO/fr.romainvigier.MetadataCleaner/figures/add-folders-button.png:/usr/share/help/nn/fr.romainvigier.MetadataCleaner/figures/add-folders-button.png metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/zh_TW/fr.romainvigier.MetadataCleaner/figures/clean-button.png /usr/share/help/C/fr.romainvigier.MetadataCleaner/figures/clean-button.png metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/zh_TW/fr.romainvigier.MetadataCleaner/figures/icon.svg /usr/share/help/C/fr.romainvigier.MetadataCleaner/figures/icon.svg:/usr/share/help/ar/fr.romainvigier.MetadataCleaner/figures/icon.svg:/usr/share/help/az/fr.romainvigier.MetadataCleaner/figures/icon.svg:/usr/share/help/bn/fr.romainvigier.MetadataCleaner/figures/icon.svg:/usr/share/help/ca/fr.romainvigier.MetadataCleaner/figures/icon.svg:(and 34 more) metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/zh_TW/fr.romainvigier.MetadataCleaner/figures/metadata-example.png /usr/share/help/C/fr.romainvigier.MetadataCleaner/figures/metadata-example.png metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/nb_NO/fr.romainvigier.MetadataCleaner/figures/clean-button.png /usr/share/help/da/fr.romainvigier.MetadataCleaner/figures/clean-button.png metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/pt_BR/fr.romainvigier.MetadataCleaner/figures/clean-button.png /usr/share/help/gl/fr.romainvigier.MetadataCleaner/figures/clean-button.png:/usr/share/help/pt/fr.romainvigier.MetadataCleaner/figures/clean-button.png metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/pt_BR/fr.romainvigier.MetadataCleaner/figures/add-folders-button.png /usr/share/help/pt/fr.romainvigier.MetadataCleaner/figures/add-folders-button.png metadata-cleaner-langpacks.noarch: W: files-duplicate /usr/share/help/pt_BR/fr.romainvigier.MetadataCleaner/figures/metadata-example.png /usr/share/help/pt/fr.romainvigier.MetadataCleaner/figures/metadata-example.png metadata-cleaner.noarch: W: files-duplicate /usr/share/metadata-cleaner/src/metadatacleaner/ui/__init__.py /usr/share/metadata-cleaner/src/metadatacleaner/__init__.py:/usr/share/metadata-cleaner/src/metadatacleaner/modules/__init__.py 2 packages and 0 specfiles checked; 1 errors, 12 warnings, 7 filtered, 1 badness; has taken 0.3 s Source checksums ---------------- https://gitlab.com/rmnvgr/metadata-cleaner/-/archive/v2.5.4/metadata-cleaner-v2.5.4.tar.bz2 : CHECKSUM(SHA256) this package : 672151f381863233de83d8ae3a21b7329a4c5299741ed0694c35b4900180f81d CHECKSUM(SHA256) upstream package : 672151f381863233de83d8ae3a21b7329a4c5299741ed0694c35b4900180f81d Requires -------- metadata-cleaner (rpmlib, GLIBC filtered): /usr/bin/python3 dbus-common gtk4 libadwaita mat2 metadata-cleaner-langpacks (rpmlib, GLIBC filtered): metadata-cleaner Provides -------- metadata-cleaner: application() application(fr.romainvigier.MetadataCleaner.desktop) metadata-cleaner metainfo() metainfo(fr.romainvigier.MetadataCleaner.metainfo.xml) metadata-cleaner-langpacks: metadata-cleaner-langpacks Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2243131 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Shell-api Disabled plugins: Python, Perl, Haskell, R, PHP, fonts, SugarActivity, C/C++, Java, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comment: a) Still get directory ownership problem. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2243131 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202243131%23c17 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
