https://bugzilla.redhat.com/show_bug.cgi?id=2274849 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is almost exactly as generated by rust2rpm, greatly simplifying the review. The only differences are: 1. The tests are disabled due to an unpackaged test dependency. -%bcond_without check +# * missing dev-dependencies: ui_test ^0.7 +%bcond_with check %global debug_package %{nil} Packaging this would require some updates, Problem 1: nothing provides requested (crate(annotate-snippets/default) >= 0.10.0 with crate(annotate-snippets/default) < 0.11.0~) and quite a new packages, Problem 2: nothing provides requested (crate(color-eyre) >= 0.6.1 with crate(color-eyre) < 0.7.0~) Problem 3: nothing provides requested (crate(color-eyre/capture-spantrace) >= 0.6.1 with crate(color-eyre/capture-spantrace) < 0.7.0~) Problem 4: nothing provides requested (crate(comma/default) >= 1.0.0 with crate(comma/default) < 2.0.0~) Problem 5: nothing provides requested (crate(levenshtein/default) >= 1.0.5 with crate(levenshtein/default) < 2.0.0~) Problem 6: nothing provides requested (crate(prettydiff) >= 0.6.4 with crate(prettydiff) < 0.7.0~) Problem 7: nothing provides requested (crate(spanned/default) >= 0.1.6 with crate(spanned/default) < 0.2.0~) so disabling the tests seems reasonable under the circumstances. 2. The nu-ansi-term dependency version is bumped from 0.49 to 0.50. +# Manually created patch for downstream crate metadata changes +# * bump nu-ansi-term dependency from 0.49 to 0.50 +Patch: tracing-tree-fix-metadata.diff This, too, seems reasonable, but I went ahead and proposed it upstream too: https://github.com/davidbarsky/tracing-tree/pull/80 All tests passed with "cargo test" and "cargo test --release". Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/tracing- tree-0.3.0/LICENSE-APACHE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files This is not a serious problem, and should be fixed in rust2rpm if it is a problem at all. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License". 34 files have unknown license. Detailed output of licensecheck in /home/ben/Downloads/review/2274849-rust-tracing- tree/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share, /usr/share/cargo/registry, /usr, /usr/share/cargo (Spurious diagnostic; fedora-review bug) [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share, /usr/share/cargo, /usr/share/cargo/registry, /usr (Spurious diagnostic; fedora-review bug) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- tracing-tree-devel , rust-tracing-tree+default-devel , rust-tracing- tree+time-devel , rust-tracing-tree+tracing-log-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. You might consider linking https://github.com/davidbarsky/tracing-tree/pull/80. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=116319436 [!]: %check is present and all tests pass. Tests are disabled due to an excessive dependency tree. This is not ideal, but seems acceptable under the circumstances. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-tracing-tree-devel-0.3.0-1.fc41.noarch.rpm rust-tracing-tree+default-devel-0.3.0-1.fc41.noarch.rpm rust-tracing-tree+time-devel-0.3.0-1.fc41.noarch.rpm rust-tracing-tree+tracing-log-devel-0.3.0-1.fc41.noarch.rpm rust-tracing-tree-0.3.0-1.fc41.src.rpm =========================================================================================== rpmlint session starts ========================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmplbfmdiir')] checks: 32, packages: 5 rust-tracing-tree+default-devel.noarch: W: no-documentation rust-tracing-tree+time-devel.noarch: W: no-documentation rust-tracing-tree+tracing-log-devel.noarch: W: no-documentation ===================================================== 5 packages and 0 specfiles checked; 0 errors, 3 warnings, 22 filtered, 0 badness; has taken 0.3 s ===================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 rust-tracing-tree+time-devel.noarch: W: no-documentation rust-tracing-tree+default-devel.noarch: W: no-documentation rust-tracing-tree+tracing-log-devel.noarch: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 3 warnings, 18 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://crates.io/api/v1/crates/tracing-tree/0.3.0/download#/tracing-tree-0.3.0.crate : CHECKSUM(SHA256) this package : 65139ecd2c3f6484c3b99bc01c77afe21e95473630747c7aca525e78b0666675 CHECKSUM(SHA256) upstream package : 65139ecd2c3f6484c3b99bc01c77afe21e95473630747c7aca525e78b0666675 Requires -------- rust-tracing-tree-devel (rpmlib, GLIBC filtered): (crate(nu-ansi-term/default) >= 0.50.0 with crate(nu-ansi-term/default) < 0.51.0~) (crate(tracing-core/default) >= 0.1.0 with crate(tracing-core/default) < 0.2.0~) (crate(tracing-subscriber) >= 0.3.0 with crate(tracing-subscriber) < 0.4.0~) (crate(tracing-subscriber/fmt) >= 0.3.0 with crate(tracing-subscriber/fmt) < 0.4.0~) (crate(tracing-subscriber/registry) >= 0.3.0 with crate(tracing-subscriber/registry) < 0.4.0~) (crate(tracing-subscriber/std) >= 0.3.0 with crate(tracing-subscriber/std) < 0.4.0~) cargo rust rust-tracing-tree+default-devel (rpmlib, GLIBC filtered): cargo crate(tracing-tree) crate(tracing-tree/tracing-log) rust-tracing-tree+time-devel (rpmlib, GLIBC filtered): (crate(time/default) >= 0.3.20 with crate(time/default) < 0.4.0~) (crate(time/formatting) >= 0.3.20 with crate(time/formatting) < 0.4.0~) (crate(time/local-offset) >= 0.3.20 with crate(time/local-offset) < 0.4.0~) cargo crate(tracing-tree) rust-tracing-tree+tracing-log-devel (rpmlib, GLIBC filtered): (crate(tracing-log) >= 0.2.0 with crate(tracing-log) < 0.3.0~) (crate(tracing-log/log-tracer) >= 0.2.0 with crate(tracing-log/log-tracer) < 0.3.0~) (crate(tracing-log/std) >= 0.2.0 with crate(tracing-log/std) < 0.3.0~) cargo crate(tracing-tree) Provides -------- rust-tracing-tree-devel: crate(tracing-tree) rust-tracing-tree-devel rust-tracing-tree+default-devel: crate(tracing-tree/default) rust-tracing-tree+default-devel rust-tracing-tree+time-devel: crate(tracing-tree/time) rust-tracing-tree+time-devel rust-tracing-tree+tracing-log-devel: crate(tracing-tree/tracing-log) rust-tracing-tree+tracing-log-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2274849 --mock-options=--dnf Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Haskell, Java, PHP, fonts, Perl, Ocaml, SugarActivity, Python, C/C++, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2274849 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202274849%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
