Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-build - GNOME build framework https://bugzilla.redhat.com/show_bug.cgi?id=428566 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-01-21 12:55 EST ------- For 0.2.0-2: * pkgconfig .pc file <-> -devel package Requires - %_libdir/pkgconfig/%name-1.0.pc contains: ----------------------------------------------------------- 10 Requires: libgnome-2.0 gtk+-2.0 libxml-2.0 gdl-1.0 gdl-gnome-1.0 ----------------------------------------------------------- This means that %name-devel package should have "Requires: libgnome-devel, libxml2-devel, libgdl-devel" as well as "Requires: gtk2-devel". However, are these Requires actually needed? (gtk2-devel is really needed as header files in gnome-build-devel actually requires header files in gtk2-devel). Please either - add more Requires to gnome-build-devel - or fix pkgconfig file. * Timestamps - To keep timestamps on installed files, I usually recommend to use: ----------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ----------------------------------------------------------- This usually works for recent autotool-based Makefiles. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review