https://bugzilla.redhat.com/show_bug.cgi?id=2274250 --- Comment #4 from Davide Cavalca <davide@xxxxxxxxxxxx> --- Thanks! > Why are clblast, tclap and sha2 bundled ? clblast is a heavily cut down and modified copy of the datafiles that clblast upstream provides; tclap is a modified copy of a oneoff upstream version; sha2 is a modified copy and it's deeply integrated into the source. > could a %check be added ? > maybe katago runtests The tests don't work without a model > Where is model ? https://katagotraining.org, see the included README.fedora. This changes often and doesn't have a stable URI, so I didn't think it made sense to include it in the package. > And looking for default in bin/ is not great. Agreed, afaict it looks for where the binary is, but the code wasn't super clear. I'll get an upstream issue filed for this. > katago.x86_64: W: package-with-huge-docs 99% > This package is mostly /usr/share/katago/doc, maybe have a doc subpackage. Sure, I can do that. It would mean the main package becomes just empty, which is probably fine. > some lint errors I suspect these are all side effects of alternatives not playing well with rpmlint, but I will double check. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2274250 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202274250%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
