https://bugzilla.redhat.com/show_bug.cgi?id=2273288 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |ngompa13@xxxxxxxxx CC| |ngompa13@xxxxxxxxx Flags| |fedora-review+ Doc Type|--- |If docs needed, set a value Status|NEW |POST --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- Spec review notes to fix on import: > Requires: pkgconfig This is unneeded and redundant for the autogenerated one > %ldconfig_scriptlets This is unneeded for RHEL 8+ and Fedora. Please drop it. > %{_libdir}/lib%{name}.so.* Please capture the soversion properly in the spec. > %{_includedir}/%{name}-%{version} Please add a trailing slash here. Overall package review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled and recorded * No serious issues from rpmlint PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2273288 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202273288%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
