https://bugzilla.redhat.com/show_bug.cgi?id=1517451 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? | |needinfo?(oka@xxxxxx) | |needinfo?(oka@xxxxxx) Assignee|nobody@xxxxxxxxxxxxxxxxx |dominik@xxxxxxxxxxxxxx --- Comment #41 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- (In reply to Dominik 'Rathann' Mierzejewski from comment #40) [...] > To elaborate, girl appears to be maintained upstream: > https://gitlab.gnome.org/GNOME/gnome-internet-radio-locator > > Last commit was 4 months ago. Ok, upon further reading it does seem like upstream intends to replace it with gtk-radio. I guess we should proceed here, then. Some review comments below: Provides: gtk-internet-radio-locator >= 128.0 Drop the greater-than, this should be equal only. You are also mixing tabs and spaces, please replace tabs with spaces in: Obsoletes:<TAB>gtk-internet-radio-locator <= 128.0 Provides:<TAB>gtk-internet-radio-locator = 128.0 %post section is empty, drop it. License: tag is not SPDX-compliant, please fix. %{_mandir}/man1/gnome-radio.1.gz %{_mandir}/man1/gtk-internet-radio-locator.1.gz These should be: %{_mandir}/man1/gnome-radio.1.* %{_mandir}/man1/gtk-internet-radio-locator.1.* and moved next to: %{_mandir}/man1/%{name}.1* building on rawhide-x86_64 fails with: ... configure: error: in `/builddir/build/BUILD/gtk-radio-264.1': configure: error: C compiler cannot create executables See `config.log' for more details config.log duly informs that you forgot to add explicit BuildRequires: gcc: ... configure:4251: gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTI> ./configure: line 4253: gcc: command not found After fixing that, I get: Package 'geoclue-2.0', required by 'virtual:world', not found Package 'libgeoclue-2.0', required by 'virtual:world', not found After fixing that (BuildRequires: pkgconfig(geoclue-2.0)), I get a warning: configure: WARNING: You will not be able to create source packages with 'make dist' because gtk-doc >= 1.16 is not found. and then a compilation error: gnome-radio-location.c: In function ‘location_main’: gnome-radio-location.c:193:27: error: passing argument 3 of ‘gclue_simple_new’ makes pointer from integer without a cast [-Wint-conversion] 193 | time_threshold, | ^~~~~~~~~~~~~~ | | | gint {aka int} and tons of warnings about deprecated GTimeVal usage, e.g.: gnome-radio-location.c:89:9: warning: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead [-Wdeprecated-declarations] This looks suspicious as well: In file included from /usr/include/libgeoclue-2.0/geoclue.h:35, from gnome-radio-location.c:33: /usr/include/libgeoclue-2.0/gclue-simple.h:65:64: note: expected ‘GCancellable *’ {aka ‘struct _GCancellable *’} but argument is of type ‘gint’ {aka ‘int’} 65 | GCancellable *cancellable, | ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ I'd be happy to sponsor you once this package is ready for Fedora Rawhide. Since Robert-André is no longer assigned here, I'll pick up the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1517451 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201517451%23c41 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
