[Bug 2270362] Review Request: golang-github-jackc-pgx5 - PostgreSQL driver and toolkit for Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2270362

Maxwell G <maxwell@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |maxwell@xxxxxxx
              Flags|                            |fedora-review+
           Doc Type|---                         |If docs needed, set a value



--- Comment #2 from Maxwell G <maxwell@xxxxxxx> ---
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is
justified.
- [x] The License tag reflects the package contents and uses the correct
identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.

- [x] The package runs tests in %check.

NOTE: Do you want to add `trap 'pg_ctl stop -D "$DATA_DIR"' EXIT` in there?

- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the
distribution. (Some Go projects include utility binaries with very generic
names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these
by default)
- [?] The package does not use `%gometa -f` if it has dependents that still
build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the
Bodhi ticket.

Thanks!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2270362

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202270362%23c2
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux