Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Freemind - Mind mapping tool https://bugzilla.redhat.com/show_bug.cgi?id=428413 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-01-21 11:18 EST ------- First of all, when tarball contains some problematic codes, we requests that you must remove the codes _in advance_ and repackage the tarball. Please refer to the section "When Upstream uses Prohibited Code" of http://fedoraproject.org/wiki/Packaging/SourceURL ! Please write where the original tarball can be gained in spec file ! And also write how you created your original tarball with ! problematic codes removed. For 0.9.0-3: ===================================================================================== Source0: Now okay as GPLv2+ if you remove problematic codes in advance and repackage it. (perhaps, expect for some binaries written below) Source1: Public Domain Source2: Okay as GPLv2+ (perhaps, except for some binaries written below) Source3: NOT OKAY lib/ant/LICENSE.txt - ASLv1.1, GPL incompatible. Files under lib/ant must be removed. Source4: BSD and MIT, okay for GPLv2+. Source5: BSD, okay for GPLv2+ ======================================================================================== * First release number - As said above, the release number "-3" is not proper for pre-release tarball. ref: "Pre-Release packages" of http://fedoraproject.org/wiki/Packaging/NamingGuidelines * Source - For Source2, do you have any reason you don't want to use released zip file http://downloads.sourceforge.net/simplyhtml/shtml_0_12_2_beta1.zip ? If so, would you rename Source2 so that it clearly shows what day of CVS code you used as tarball? - For Source3, please pull codes from CVS as written on http://www.xmlpull.org/v1/doc/faq.html#CVS * Pre-rebuilt binary files - Please clean up all pre-built binary files (especially .jar files) at %prep like: --------------------------------------------------------------------- %prep .... find freemind -name \*.jar -exec rm -f {} ';' --------------------------------------------------------------------- to make sure that we are shipping all rebuilt files. - There are some other binaries in freemind tarball. I am not sure what they are and also unsure how they are used. --------------------------------------------------------------------- plugins/help/doc/JavaHelpSearch/DOCS: data plugins/help/doc/JavaHelpSearch/DOCS.TAB: data plugins/help/doc/JavaHelpSearch/OFFSETS: data plugins/help/doc/JavaHelpSearch/POSITIONS: DBase 3 data file with memo(s) plugins/help/doc/JavaHelpSearch/TMAP: data windows-launcher/Freemind.exe: MS-DOS executable PE for MS Windows (GUI) Intel 80386 32-bit windows-launcher/Freemind_light_bulb.exe: MS-DOS executable PE for MS Windows (GUI) Intel 80386 32-bit --------------------------------------------------------------------- I guess the last 2 files can be simply ignored, however would you tell me for the former 4 files? - Also similar files are found under src/com/lightdev/app/shtm/help/JavaHelpSearch in shtml.tar.gz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review