[Bug 2257179] Review Request: qmplay2 - Qt based media player, streamer and downloader

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2257179



--- Comment #7 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> ---
Provides: bundled(qmvk) = qmvk_version

still missing.

rm -f %{buildroot}%{_datadir}/qmplay2/{LICENSE,README.md}

still not changed to rm -v. You will likely miss it when these files are
(re)moved by upstream and this can be dropped.

Also, it doesn't build on rawhide:

https://koji.fedoraproject.org/koji/taskinfo?taskID=115915386

...
/builddir/build/BUILD/QMPlay2-src-24.03.16/src/modules/FFmpeg/FFDecSW.cpp:609:60:
error: cannot convert ‘QStringBuilder<const char (&)[29], QByteArray&>’ to
‘const QString&’
  609 |         QMPlay2Core.logInfo("Converting to pixel format: " +
desiredPixFmtName);
      |                            
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
      |                                                            |
      |                                                           
QStringBuilder<const char (&)[29], QByteArray&>
In file included from
/builddir/build/BUILD/QMPlay2-src-24.03.16/src/qmplay2/Settings.hpp:21,
                 from
/builddir/build/BUILD/QMPlay2-src-24.03.16/src/qmplay2/Module.hpp:25:


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2257179

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257179%23c7
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux