[Bug 2254933] Review Request: perl-Future-HTTP - Future::HTTP Perl module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2254933

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #7 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Changes in the spec file:

--- perl-Future-HTTP.spec.old   2024-03-08 01:00:00.000000000 +0100
+++ perl-Future-HTTP.spec       2024-04-03 02:00:00.000000000 +0200
@@ -1,28 +1,27 @@
+# some tests require Internet access, don't enable by default
+%bcond network_tests 0
+
 Name:           perl-Future-HTTP
 Version:        0.16
-Release:        4%{?dist}
+Release:        5%{?dist}
 Summary:        Future::HTTP Perl module
 License:        GPL-1.0-or-later OR Artistic-1.0-Perl
-URL:            https://metacpan.org/dist/Future-HTTP/
+URL:            https://metacpan.org/dist/Future-HTTP
 Source0:       
https://cpan.metacpan.org/authors/id/C/CO/CORION/Future-HTTP-%{version}.tar.gz
 BuildArch:      noarch
 BuildRequires:  make perl-interpreter perl-generators coreutils
 BuildRequires:  perl(AnyEvent)
 BuildRequires:  perl(AnyEvent::Future)
 BuildRequires:  perl(AnyEvent::HTTP)
-BuildRequires:  perl(CGI)
 BuildRequires:  perl(Data::Dumper)
 BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76
 BuildRequires:  perl(Fcntl)
 BuildRequires:  perl(Filter::signatures) >= 0.13
 BuildRequires:  perl(Future) >= 0.31
 BuildRequires:  perl(Future::Mojo)
-BuildRequires:  perl(HTTP::Headers) >= 6.07
-BuildRequires:  perl(HTTP::Request)
-BuildRequires:  perl(HTTP::Request::AsCGI)
+BuildRequires:  perl(HTTP::Request) >= 6.07
 BuildRequires:  perl(HTTP::Tiny)
-BuildRequires:  perl(HTTP::Tiny::Paranoid)
-BuildRequires:  perl(IO::Async)
+BuildRequires:  perl(HTTP::Tiny::Paranoid) >= 0.07
 BuildRequires:  perl(IO::Async::Future)
 BuildRequires:  perl(IO::Async::Loop)
 BuildRequires:  perl(IO::Uncompress::Bunzip2)
@@ -31,7 +30,6 @@
 BuildRequires:  perl(IO::Uncompress::RawInflate)
 BuildRequires:  perl(MIME::Base64)
 BuildRequires:  perl(MIME::QuotedPrint)
-BuildRequires:  perl(Mojo::IOLoop)
 BuildRequires:  perl(Mojo::UserAgent)
 BuildRequires:  perl(Mojolicious)
 BuildRequires:  perl(Moo) >= 2
@@ -57,11 +55,15 @@
 Requires:       perl(warnings)

 %description
-Provide the most appropriate HTTP client with a Future API
+This module is a wrapper combining Future with the API provided by
+AnyEvent::HTTP. The backend used for the HTTP protocols depends on
+whether one of the event loops is loaded.

 %prep
 %setup -q -n Future-HTTP-%{version}
-%{!?_with_network_tests: rm t/01-http-tiny-paranoid.t }
+%if %{without network_tests}
+rm t/01-http-tiny-paranoid.t
+%endif
 perl -pi -e 's/\r//' Changes

 %build
@@ -79,11 +81,14 @@
 %doc Changes README
 # note: files all say perl_5 which is GPLv1/Artistic but file is Artistic-2
 # https://rt.cpan.org/Ticket/Display.html?id=152217
-#%license LICENSE
+#license LICENSE
 %{perl_vendorlib}/Future/HTTP*
 %{_mandir}/man3/Future::HTTP*

 %changelog
+* Wed Apr 03 2024 Chris Adams <linux@xxxxxxxxxxx> 0.16-5
+- additional spec file cleanups
+
 * Fri Mar 08 2024 Chris Adams <linux@xxxxxxxxxxx> 0.16-4
 - additional spec file cleanups


FIX: The current summary is not well descriptive. Use e.g. "HTTP client with a
Future API" (see lib/Future/HTTP.pm POD).

$ rpmlint perl-Future-HTTP.spec ../SRPMS/perl-Future-HTTP-0.16-5.fc41.src.rpm 
../RPMS/noarch/perl-Future-HTTP-0.16-5.fc41.noarch.rpm 
======================================== rpmlint session starts
=======================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

=== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 8 filtered, 0
badness; has taken 0.4 s ==
rpmlint is Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Future-HTTP-0.16-5.fc41.noarch.rpm |
sort -f | uniq -c
      1 perl(AnyEvent::Future)
      1 perl(AnyEvent::HTTP)
      1 perl(Data::Dumper)
      1 perl(Fcntl)
      1 perl(feature)
      1 perl(Filter::signatures)
      1 perl(Future)
      1 perl(Future::Mojo)
      1 perl(HTTP::Request)
      1 perl(HTTP::Tiny)
      1 perl(HTTP::Tiny::Paranoid) >= 0.07
      1 perl(IO::Async::Future)
      1 perl(IO::Async::Loop)
      1 perl(IO::Uncompress::Bunzip2)
      1 perl(IO::Uncompress::Gunzip)
      1 perl(IO::Uncompress::Inflate)
      1 perl(IO::Uncompress::RawInflate)
      1 perl(MIME::Base64)
      1 perl(MIME::QuotedPrint)
      1 perl(Mojo::UserAgent)
      1 perl(Moo) >= 2
      1 perl(Moo::Role)
      1 perl(Net::Async::HTTP)
      1 perl(strict)
      1 perl(URI)
      1 perl(warnings)
      1 perl-libs
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
TODO: Constrain 'perl(HTTP::Request)' with '>= 6.07' (Makefile.PL:76).

The package builds in Fedora 41
(https://koji.fedoraproject.org/koji/taskinfo?taskID=115865838). Ok..

Please correct the FIX item and consider fixing the TODO item before building
this package.
This package is APPROVED.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2254933

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254933%23c7
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux