https://bugzilla.redhat.com/show_bug.cgi?id=2272258 --- Comment #7 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Maxwell G from comment #5) > This is the first package to use > https://gitlab.com/fedora/sigs/go/go-vendor-tools, the new tooling for > vendoring Go packages, and is actually an optional dependency of > go-vendor-tools itself, so there is still some work to do. See the > discussion in > https://lists.fedoraproject.org/archives/list/golang@xxxxxxxxxxxxxxxxxxxxxxx/ > thread/K5P6P2MGEE3SCPF4SZFWOIUGHQHJ6GGG/. I apologize for missing some > context with this review request. I had expected for a Go SIG member who had > participated in the previous discussions to review the package, but your > review is very welcome. Thank you! If some Go SIG member wants to take over this review, I am happy to hand it over. I actually have reviewed Go packages before, but it's been awhile, and I am clearly not up on the latest developments. > > There don't seem to be any golang packaging guidelines > > These do exist in > https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/, but don't > cover the new tooling yet. Okay. I expected to find a link in https://docs.fedoraproject.org/en-US/packaging-guidelines/#_domain_specific_guidelines, but I don't see one there. I am satisfied with your other answers. (I didn't know "%license %dir" was a thing. I'm glad that works!) I look forward to the next iteration. Thanks for doing the work to get trivy packaged. It will be a great addition to Fedora. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2272258 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202272258%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
