[Bug 2272499] Review Request: sqlfluff - Modular SQL linter and auto-formatter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2272499



--- Comment #9 from Arthur Bols <arthur@xxxxxxxx> ---
Thanks for you help!

> Anyway, do you know how much it needs sqlfluff to be installed? Can you point PYTHONPATH to the build directory, like this?

It needs sqlfluff to generate the rules for the documentation in a separate
script `docs/generate-rule-docs.py`. So it's quite important.

I can't fix it with only `PYTHONPATH=build/lib`, because sqlfluff calls
metadata.version in __init__.py. The following seems to work (I guess because
there is a sqlfluff.egg-info...?):

    PYTHONPATH="../:../build/lib" %{python3} generate-rule-docs.py
    PYTHONPATH="../:../build/lib" sphinx-build source html

Is this safe/allowed? The built html seems fine, nothing special.

(In reply to Miro Hrončok from comment #8)
> Side note 2:
> 
>   %{python3} -m pip install plugins/sqlfluff-plugin-example --no-deps
> --no-index --no-warn-script-location
> 
> This installs the package to the home directory of whoever builds the
> package. As such, it MUST NOT happen.

Thanks, should've known. I've disabled the tests needing the example-plugin,
since I couldn't get it to work.

Spec URL: https://principis.fedorapeople.org/sqlfluff.spec
SRPM URL: https://principis.fedorapeople.org/sqlfluff-3.0.3-1.fc39.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2272499

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202272499%23c9
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux