https://bugzilla.redhat.com/show_bug.cgi?id=2254933 --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. TODO: Remove a trailing slash from the URL value. Source0 archive (SHA512: f9cb5d039d1b56f1939f4562b3e3a544412458a9b39d4c596f63f085399d03cd10e82fef1dc3ab3d77b71a33836e10d4babcc9f6ab94980e58a36c48c476a6dc) is original. Ok. FIX: The current summary is not well descriptive. Use e.g. "HTTP client with a Future API" (see lib/Future/HTTP.pm POD). FIX: Description text is not a sentence, it's missing a full stop. TODO: Description text is too brief. I recommend copying a paragraph from Synopsis in lib/Future/HTTP.pm POD. License verified from: Makefile.PL, README.mkdn, lib/Future/HTTP.pm, lib/Future/HTTP/Mojo.pm, lib/Future/HTTP/Tiny/Paranoid.pm, lib/Future/HTTP/NetAsync.pm, lib/Future/HTTP/Tiny.pm, lib/Future/HTTP/AnyEvent.pm, README. Ok. Note: LICENSE file is an Artistic-2.0 copy. No XS code, noarch BuildArch is Ok. TODO: Declare _with_network_tests build condition using %bcond or %bcond_without macro. perl(AnyEvent) is in optional dependency for the tests. Ok. FIX: Do not depend on 'perl(CGI)'. It's not used anywhere. FIX: Do not depend on 'perl(HTTP::Headers) >= 6.07'. It's not used. Instead apply the version constraint to 'perl(HTTP::Request)'. Upstream mistaken the two modules. FIX: Do not depend on 'perl(HTTP::Request::AsCGI)' It.s not used. TODO: Constrain 'perl(HTTP::Tiny::Paranoid)' dependency with '>= 0.07' (lib/Future/HTTP/Tiny/Paranoid.pm:4). FIX: Do not depend on 'perl(IO::Async)'. It's not used. FIX: Do not depend on 'perl(Mojo::IOLoop)'. It's not used. All tests pass. Ok. $ rpmlint perl-Future-HTTP.spec ../SRPMS/perl-Future-HTTP-0.16-4.fc41.src.rpm ../RPMS/noarch/perl-Future-HTTP-0.16-4.fc41.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-Future-HTTP.spec:82: W: macro-in-comment %license perl-Future-HTTP.spec:82: W: macro-in-comment %license === 2 packages and 1 specfiles checked; 0 errors, 2 warnings, 6 filtered, 0 badness; has taken 0.3 s == FIX: Escape a per-cent character in the comment. $ rpm -q -lv -p ../RPMS/noarch/perl-Future-HTTP-0.16-4.fc41.noarch.rpm drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/doc/perl-Future-HTTP -rw-r--r-- 1 root root 2697 Mar 8 01:00 /usr/share/doc/perl-Future-HTTP/Changes -rw-r--r-- 1 root root 1079 Jul 21 2023 /usr/share/doc/perl-Future-HTTP/README -rw-r--r-- 1 root root 2047 Mar 8 01:00 /usr/share/man/man3/Future::HTTP.3pm.gz -rw-r--r-- 1 root root 857 Mar 8 01:00 /usr/share/man/man3/Future::HTTP::API::HTTPTiny.3pm.gz -rw-r--r-- 1 root root 1820 Mar 8 01:00 /usr/share/man/man3/Future::HTTP::AnyEvent.3pm.gz -rw-r--r-- 1 root root 856 Mar 8 01:00 /usr/share/man/man3/Future::HTTP::Handler.3pm.gz -rw-r--r-- 1 root root 1876 Mar 8 01:00 /usr/share/man/man3/Future::HTTP::Mojo.3pm.gz -rw-r--r-- 1 root root 1873 Mar 8 01:00 /usr/share/man/man3/Future::HTTP::NetAsync.3pm.gz -rw-r--r-- 1 root root 2063 Mar 8 01:00 /usr/share/man/man3/Future::HTTP::Tiny.3pm.gz -rw-r--r-- 1 root root 2206 Mar 8 01:00 /usr/share/man/man3/Future::HTTP::Tiny::Paranoid.3pm.gz drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/perl5/vendor_perl/Future/HTTP -rw-r--r-- 1 root root 5301 Jul 21 2023 /usr/share/perl5/vendor_perl/Future/HTTP.pm drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/perl5/vendor_perl/Future/HTTP/API -rw-r--r-- 1 root root 3716 Jul 21 2023 /usr/share/perl5/vendor_perl/Future/HTTP/API/HTTPTiny.pm -rw-r--r-- 1 root root 3898 Jul 21 2023 /usr/share/perl5/vendor_perl/Future/HTTP/AnyEvent.pm -rw-r--r-- 1 root root 5278 Jul 21 2023 /usr/share/perl5/vendor_perl/Future/HTTP/Handler.pm -rw-r--r-- 1 root root 5191 Jul 21 2023 /usr/share/perl5/vendor_perl/Future/HTTP/Mojo.pm -rw-r--r-- 1 root root 5298 Jul 21 2023 /usr/share/perl5/vendor_perl/Future/HTTP/NetAsync.pm drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/perl5/vendor_perl/Future/HTTP/Tiny -rw-r--r-- 1 root root 5568 Jul 21 2023 /usr/share/perl5/vendor_perl/Future/HTTP/Tiny.pm -rw-r--r-- 1 root root 3880 Jul 21 2023 /usr/share/perl5/vendor_perl/Future/HTTP/Tiny/Paranoid.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Future-HTTP-0.16-4.fc41.noarch.rpm | sort -f | uniq -c 1 perl(AnyEvent::Future) 1 perl(AnyEvent::HTTP) 1 perl(Data::Dumper) 1 perl(Fcntl) 1 perl(feature) 1 perl(Filter::signatures) 1 perl(Future) 1 perl(Future::Mojo) 1 perl(HTTP::Request) 1 perl(HTTP::Tiny) 1 perl(HTTP::Tiny::Paranoid) >= 0.07 1 perl(IO::Async::Future) 1 perl(IO::Async::Loop) 1 perl(IO::Uncompress::Bunzip2) 1 perl(IO::Uncompress::Gunzip) 1 perl(IO::Uncompress::Inflate) 1 perl(IO::Uncompress::RawInflate) 1 perl(MIME::Base64) 1 perl(MIME::QuotedPrint) 1 perl(Mojo::UserAgent) 1 perl(Moo) >= 2 1 perl(Moo::Role) 1 perl(Net::Async::HTTP) 1 perl(strict) 1 perl(URI) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: Constrain 'perl(HTTP::Request)' with '>= 6.07' (Makefile.PL:76). $ rpm -q --provides -p ../RPMS/noarch/perl-Future-HTTP-0.16-4.fc41.noarch.rpm | sort -f | uniq -c 1 perl(Future::HTTP) = 0.16 1 perl(Future::HTTP::AnyEvent) = 0.16 1 perl(Future::HTTP::Handler) = 0.16 1 perl(Future::HTTP::Mojo) = 0.16 1 perl(Future::HTTP::NetAsync) = 0.16 1 perl(Future::HTTP::Tiny) = 0.16 1 perl(Future::HTTP::Tiny::Paranoid) = 0.16 1 perl-Future-HTTP = 0.16-4.fc41 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Future-HTTP-0.16-4.fc41.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 41 <https://koji.fedoraproject.org/koji/taskinfo?taskID=115787008>. Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Please correct FIX items, consider fixing TODO items and provide an updated spec file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2254933 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254933%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
