https://bugzilla.redhat.com/show_bug.cgi?id=2270021 --- Comment #14 from Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> --- Hi Benson, Thank you for explaining in detail! I fixed the issues as followings. Spec URL: https://hiwkby.fedorapeople.org/python-pyngus.spec SRPM URL: https://hiwkby.fedorapeople.org/python-pyngus-2.3.0%5e20200513git60b6f10-1.20200513git60b6f10.fc41.src.rpm (In reply to Benson Muite from comment #13) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > ...(snip)... > > Comments: > a) Please change: > > Source0: %{pypi_source %{srcname} %{version}} > > BuildArch: noarch > > %global _description \ > > to > > Source0: %{pypi_source %{srcname} %{version}} > > BuildArch: noarch > BuildRequires: python3-devel > > %global _description \ I added the "BuildRequires: python3-devel" line. I changed the "Source" URL to include the tests. > b) It is possible to package leading git commit directly, rather than the > pypi source > if you want to include the tests: > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > #_commit_revision > https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ > #_snapshots > > alternatively modify > > %pyproject_save_files -l %{srcname} > > %files -n python3-%{srcname} -f %{pyproject_files} > %doc README.md > > > to > > %pyproject_save_files -l %{srcname} > > %check > %pyproject_check_import > > %files -n python3-%{srcname} -f %{pyproject_files} > %doc README.md I updated the version tag to use the commit hash associated with the "2.3.1" version on pypi. I also added the "%pyproject_check_import" macro and the lines to run tests. Koji scratch build result(success) https://koji.fedoraproject.org/koji/taskinfo?taskID=115750893 Thanks in advance, Hirotaka -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2270021 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202270021%23c14 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
