Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gstream - Simplified stream output/input for Allegro https://bugzilla.redhat.com/show_bug.cgi?id=429450 ------- Additional Comments From j.w.r.degoede@xxxxxx 2008-01-21 05:37 EST ------- (In reply to comment #1) Thanks for taking a look at this! > I've got two issues here > a) mock build fails with: > > Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.26053 > + umask 022 > + cd /builddir/build/BUILD > + cd gstream16 > + LANG=C > + export LANG > + unset DISPLAY > + make -j3 -f Makefile.unx MAKEDOC=/usr/bin/allegro-makedoc 'OFLAGS=-O2 -g -pipe > -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexception > s -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -fPIC' > Missing the makedoc utility from Allegro! Please copy the makedoc executable > from allegro/docs to this directory. > + rm test.o > rm: cannot remove `test.o': No such file or directory > error: Bad exit status from /var/tmp/rpm-tmp.26053 (%build) > > This happens despite having allegro-devel installed. > Erm, oops, my bad, allegro-devel was "missing" makedoc (not install by make install, but appearantly needed by some apps). Since I'm also the allegro maintainer I fixed this, but I never committed let alone build my changes (other then a local build). I'm currently working on fixing allegro <-> pulseaudio interaction, when I'm done with that I'll push a new allegro to devel, F-8 and F-7 which does include makedoc (which I've name allegro-makedoc as makedoc is a bit generic). I'll add a note here once the new allegro is done. > b) I've noticed that you pass some custom flags to gcc when building > libgstrm.so.0. Due to the failed build, I did not reach this point so I could > not see what flags are actually used, so I figured I'd better ask, just in case: > shouldn't RPM_OPT_FLAGS be used here, too ? Yes, you're right I'll fix this after a full review is done, as I would like to keep the number of iterations (== work for both of us) to a minimum. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review