https://bugzilla.redhat.com/show_bug.cgi?id=2227804 David Timms <dtimms@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dtimms@xxxxxxxxxxxx --- Comment #15 from David Timms <dtimms@xxxxxxxxxxxx> --- (In reply to Jerry James from comment #14) > - My reading of the Snapshots part of the Versioning guide: > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ > #_snapshots > is that the snapshot part goes in the Version field, not the Release field. I don't think that is correct Jerry. However, Matthieu: in the value: Release: 4^%{snapdate}git%{shortcommit}%{?dist} , what is the caret do/for ? In the past, it would be '.', and '^' wouldn't be allowed. Some examples (from rpm-specs.latest.tar.xz (form 2023-12-24)): yosyshq-abc.spec:Release: 1.%{snapdate}git%{shortcommit0}%{?dist} And if the source is pre-release, then perhaps a leading '0.' as in the following egs: catalyst.spec:Release: 0.7.20201218git%{shortcommit}%{?dist} calypso.spec:Release: 0.12.%{date}git%{shortcommit}%{?dist} js-jquery-ui-touch-punch.spec:Release: 0.15.20141219git%{shortcommit}%{?dist} So maybe version-release should expand to be: 2.0.0-0.4.20230824git1140086 Also, seems like there is newer commits/snapshots which could/should be used instead? What do you think Jerry? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2227804 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202227804%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue