https://bugzilla.redhat.com/show_bug.cgi?id=2270021 --- Comment #8 from Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> --- Hello Benson, Thanks for the comments, I have fixed the issues as followings. Spec URL: https://hiwkby.fedorapeople.org/python-pyngus.spec SRPM URL: https://hiwkby.fedorapeople.org/python-pyngus-2.3.1-3.fc41.src.rpm (In reply to Benson Muite from comment #7) > Package Review > ...(snip)... > > Comments: > a) The warning about existing repo is fine, applies to new packages to > ensure there are no name collisions. Thanks for your understanding. > b) Can some of the tests be run? As the tests are not distributed with the > source on Pypi, will need to get > source from GitHub. If tests can not be run, perhaps check the package > imports: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests > there is also a %pyproject_check_import macro This package uses sources from PyPI because the upstream distributes the latest version from PyPI. I am asking the upstream to add the latest version tag from GitHub. Please see: https://github.com/kgiusti/pyngus/issues/14 Here are the tests results in my development environment. Two test cases skipped that may require additional settings for SASL. ``` [build@0fc92489fe13 pyngus (master *)]$ PYTHONPATH=.:tests tests/test-runner -i "unit_tests.connection.CyrusTest.test_cyrus_sasl_ok" -i "unit_tests.connection.CyrusTest.test_cyrus_sasl_fail" /home/build/dev/fedora_packaging/python-pyngus/pyngus/tests/test-runner:26: DeprecationWarning: 'cgi' is deprecated and slated for removal in Python 3.13 import logging, optparse, os, struct, sys, time, traceback, types, cgi unit_tests.connection.APITest.test_abort ...................................................................................................................................................................... pass unit_tests.connection.APITest.test_accept_receiver_async ...................................................................................................................................................... pass unit_tests.connection.APITest.test_accept_receiver_dynamic_sync ............................................................................................................................................... pass unit_tests.connection.APITest.test_accept_receiver_sync ....................................................................................................................................................... pass unit_tests.connection.APITest.test_accept_sender_async ........................................................................................................................................................ pass unit_tests.connection.APITest.test_accept_sender_dynamic_sync ................................................................................................................................................. pass unit_tests.connection.APITest.test_accept_sender_sync ......................................................................................................................................................... pass unit_tests.connection.APITest.test_active_callback ............................................................................................................................................................ pass unit_tests.connection.APITest.test_connection_properties ...................................................................................................................................................... pass unit_tests.connection.APITest.test_create_destroy ............................................................................................................................................................. pass unit_tests.connection.APITest.test_create_receiver ............................................................................................................................................................ pass unit_tests.connection.APITest.test_create_sender .............................................................................................................................................................. pass unit_tests.connection.APITest.test_destroy_then_process ....................................................................................................................................................... start 2024-03-27 06:37:54,758 ERROR Connection.process() called on destroyed connection! 2024-03-27 06:37:54,760 ERROR Connection failed: Condition('amqp:resource-limit-exceeded', 'local-idle-timeout expired') 2024-03-27 06:37:54,761 ERROR Connection.process() called on destroyed connection! unit_tests.connection.APITest.test_destroy_then_process ....................................................................................................................................................... pass unit_tests.connection.APITest.test_io_input_close ............................................................................................................................................................. start 2024-03-27 06:37:54,784 ERROR Connection failed: Condition('amqp:connection:framing-error', 'connection aborted') unit_tests.connection.APITest.test_io_input_close ............................................................................................................................................................. pass unit_tests.connection.APITest.test_io_output_close ............................................................................................................................................................ skip unit_tests.common.Skipped: Skipping test - error deprecated? unit_tests.connection.APITest.test_non_reentrant_callback ..................................................................................................................................................... pass unit_tests.connection.APITest.test_open_close_polled .......................................................................................................................................................... pass unit_tests.connection.APITest.test_pipeline ................................................................................................................................................................... pass unit_tests.connection.APITest.test_properties_hostname ........................................................................................................................................................ pass unit_tests.connection.APITest.test_properties_idle_timeout .................................................................................................................................................... pass unit_tests.connection.APITest.test_reject_receiver_async ...................................................................................................................................................... pass unit_tests.connection.APITest.test_reject_receiver_no_condition_sync .......................................................................................................................................... pass unit_tests.connection.APITest.test_reject_receiver_sync ....................................................................................................................................................... pass unit_tests.connection.APITest.test_reject_sender_async ........................................................................................................................................................ pass unit_tests.connection.APITest.test_reject_sender_no_condition_sync ............................................................................................................................................ pass unit_tests.connection.APITest.test_reject_sender_sync ......................................................................................................................................................... pass unit_tests.connection.APITest.test_sasl_callbacks_old ......................................................................................................................................................... skip unit_tests.common.Skipped: Test does not apply unit_tests.connection.APITest.test_ssl_bad_no_cert ............................................................................................................................................................ pass unit_tests.connection.APITest.test_ssl_bad_no_peer_name ....................................................................................................................................................... pass unit_tests.connection.APITest.test_ssl_bad_verify_mode ........................................................................................................................................................ pass unit_tests.connection.APITest.test_ssl_client_auth_ok ......................................................................................................................................................... pass unit_tests.connection.APITest.test_ssl_client_name_fail ....................................................................................................................................................... start 2024-03-27 06:37:55,676 ERROR Connection failed: Condition('amqp:connection:framing-error', 'SSL Failure: error:0A000086:SSL routines::certificate verify failed') 2024-03-27 06:37:55,679 ERROR Connection failed: Condition('amqp:connection:framing-error', 'SSL Failure: error:0A000410:SSL routines::ssl/tls alert handshake failure') unit_tests.connection.APITest.test_ssl_client_name_fail ....................................................................................................................................................... pass unit_tests.connection.APITest.test_ssl_client_pw_fail ......................................................................................................................................................... pass unit_tests.connection.APITest.test_ssl_minimal ................................................................................................................................................................ pass unit_tests.connection.APITest.test_ssl_name_fail .............................................................................................................................................................. start 2024-03-27 06:37:56,220 ERROR Connection failed: Condition('amqp:connection:framing-error', 'SSL Failure: error:0A000410:SSL routines::ssl/tls alert handshake failure') 2024-03-27 06:37:56,221 ERROR Connection failed: Condition('amqp:connection:framing-error', 'SSL Failure: error:0A000086:SSL routines::certificate verify failed') unit_tests.connection.APITest.test_ssl_name_fail .............................................................................................................................................................. pass unit_tests.connection.APITest.test_ssl_no_verify_peer ......................................................................................................................................................... pass unit_tests.connection.APITest.test_ssl_ok ..................................................................................................................................................................... pass unit_tests.connection.APITest.test_ssl_ok_using_system_ca ..................................................................................................................................................... pass unit_tests.connection.APITest.test_ssl_pw_fail ................................................................................................................................................................ pass unit_tests.connection.APITest.test_user_context ............................................................................................................................................................... pass unit_tests.connection.SASLTest.test_sasl_disabled ............................................................................................................................................................. pass unit_tests.connection.SASLTest.test_sasl_force ................................................................................................................................................................ pass unit_tests.connection.SASLTest.test_sasl_force_false .......................................................................................................................................................... pass unit_tests.container.APITest.test_cleanup ..................................................................................................................................................................... pass unit_tests.container.APITest.test_create_connection ........................................................................................................................................................... pass unit_tests.container.APITest.test_create_destroy .............................................................................................................................................................. pass unit_tests.container.APITest.test_need_processing ............................................................................................................................................................. pass unit_tests.link.APITest.test_create_destroy ................................................................................................................................................................... pass unit_tests.link.APITest.test_credit_sync ...................................................................................................................................................................... pass unit_tests.link.APITest.test_dynamic_receiver_props ........................................................................................................................................................... pass unit_tests.link.APITest.test_multi_frame_message .............................................................................................................................................................. pass unit_tests.link.APITest.test_non_reentrant_callback ........................................................................................................................................................... start 2024-03-27 06:37:56,961 ERROR Endpoint state error: endpoint=src1, error=invalid event=REMOTE_OPENED in state=STATE_ACTIVE 2024-03-27 06:37:56,967 ERROR Endpoint state error: endpoint=src2, error=invalid event=LOCAL_OPENED in state=STATE_ACTIVE unit_tests.link.APITest.test_non_reentrant_callback ........................................................................................................................................................... pass unit_tests.link.APITest.test_pipeline_close ................................................................................................................................................................... pass unit_tests.link.APITest.test_receiver_abort ................................................................................................................................................................... pass unit_tests.link.APITest.test_receiver_close_cond_sync ......................................................................................................................................................... pass unit_tests.link.APITest.test_receiver_setup_sync .............................................................................................................................................................. pass unit_tests.link.APITest.test_send_abort ....................................................................................................................................................................... pass unit_tests.link.APITest.test_send_accepted .................................................................................................................................................................... pass unit_tests.link.APITest.test_send_close_on_ack ................................................................................................................................................................ pass unit_tests.link.APITest.test_send_deadline_idle ............................................................................................................................................................... pass unit_tests.link.APITest.test_send_expired_late_reply .......................................................................................................................................................... pass unit_tests.link.APITest.test_send_expired_no_callback ......................................................................................................................................................... pass unit_tests.link.APITest.test_send_expired_no_credit ........................................................................................................................................................... pass unit_tests.link.APITest.test_send_expired_no_reply ............................................................................................................................................................ pass unit_tests.link.APITest.test_send_modified .................................................................................................................................................................... pass unit_tests.link.APITest.test_send_presettled .................................................................................................................................................................. pass unit_tests.link.APITest.test_send_rejected .................................................................................................................................................................... pass unit_tests.link.APITest.test_send_released .................................................................................................................................................................... pass unit_tests.link.APITest.test_sender_close_cond_sync ........................................................................................................................................................... pass unit_tests.link.APITest.test_sender_setup_sync ................................................................................................................................................................ pass unit_tests.link.APITest.test_settle_modes ..................................................................................................................................................................... pass unit_tests.link.APITest.test_use_after_free ................................................................................................................................................................... pass Totals: 74 tests, 70 passed, 2 skipped, 2 ignored, 0 failed ``` > c) Can you use the %pyproject_save_files and %{pyproject_files} macros: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_example_spec_file Thanks for the comment, I fixed the spec file to use the macros. > d) License is packaged twice at: > /usr/share/licenses/python3-pyngus/LICENSE > /usr/lib/python3.12/site-packages/pyngus-2.3.1.dist-info/LICENSE > though this is ok as metadata for the file in dist-info is missing: > $ rpm -qL python3-pyngus-2.3.1-2.fc41.noarch.rpm > /usr/share/licenses/python3-pyngus/LICENSE Thanks for the checking. I changed the spec file to use %pyproject_files macro to handle %license tag. Koji scratch build result(success) https://koji.fedoraproject.org/koji/taskinfo?taskID=115497574 Thanks in advance, Hirotaka -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2270021 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202270021%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
