https://bugzilla.redhat.com/show_bug.cgi?id=2270581 --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> --- Thank you for the review, Matthieu! (In reply to Matthieu Saulnier from comment #3) > - GAP documentation MUST be installed under %{gap_libdir}/pkg or > %{gap_archdir}/pkg > This is done correctly in your package. It produces a lot of rpmlint > complaints. But it is matching the Guideline 100%. Yes, the documentation has to be installed where it is for gap itself to read it correctly. Upstream is working on a fix for this, but it hasn't landed in the main gap package yet. > - In the %%check section, a shell redirection is not needed to run the tests > suite. > That's not a blocker anyway. Thanks for noticing that. I had to introduce shell redirections for other gap-pkg-* packages a few gap releases ago. I don't remember the details of the problem now, but there was some sort of issue with gap hanging instead of exiting without the redirection. That appears to have been fixed. I'll remove the redirections from the other packages. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2270581 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202270581%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
