https://bugzilla.redhat.com/show_bug.cgi?id=2271315 --- Comment #8 from Neil Hanlon <neil@xxxxxxxx> --- Thank you for the review! I owe you at least one already, so, I will work on some for you in the next week. a) Do copies of INSTALL.md README.md need to be in both the main and doc subpackages? Probably not. Should they be in the doc package or the main subpackage? b) Should lmdb and libdb be included as a dependency: https://packages.fedoraproject.org/pkgs/lmdb/lmdb/ https://packages.fedoraproject.org/pkgs/libdb/libdb/ See: https://mapserver.org/mapcache/install.html I've asked the original spec author that I've been working with, but we don't believe they are hard dependencies. Perhaps I can add them as Suggests? c) Can tests be run: https://github.com/MapServer/mapcache/tree/main/tests I looked into these a bit but they appear to require installing and running an HTTPD server to make requests to it. I wasn't sure if these sort of tests were appropriate for rpm %check, or if they should be implemented as Zuul or tmt tests instead? d) In the files section add: %dir %{_datadir}/mapcache Done e) Two files are under BSD-3-Clause: BSD 3-Clause License -------------------- mapcache-1.14.0/lib/hmac-sha.c mapcache-1.14.0/lib/strptime.c Ack. I've modified the license to MIT AND BSD-3-Clause. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2271315 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202271315%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
